Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3206]improvement(client-python): Add Black for client-python (#3254) #3325

Merged
merged 1 commit into from
May 10, 2024

Conversation

noidname01
Copy link
Collaborator

What changes were proposed in this pull request?

  • Add Black as code formatter, it enforce the coding style with
    1. trailing commas and whitespaces
    2. unified quotation marks(")
    3. new lines
    4. max line length
    5. indents
  • Aligned with Pylint Rules
  • Add Black into Gradle and form a code formatting pipeline (pipInstall -> Black -> Pylint), this pipeline will run implicitly in build and test gradle tasks.

Note that Black still can't format long entire string exceeding max line length without enabling unstable features, please handle long strings with caution and make Pylint to ignore them if they are really necessary.

Why are the changes needed?

Fix: #3206, #3203

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

…pache#3254)

### What changes were proposed in this pull request?

* Add Black as code formatter, it enforce the coding style with 
	1. trailing commas and whitespaces
	2. unified quotation marks(")
	3. new lines
	4. max line length
	5. indents
* Aligned with Pylint Rules
* Add Black into Gradle and form a code formatting pipeline (pipInstall
-> Black -> Pylint), this pipeline will run implicitly in `build` and
`test` gradle tasks.

> Note that Black still can't format long entire string exceeding `max
line length` without enabling unstable features, please handle long
strings with caution and make Pylint to ignore them if they are really
necessary.

### Why are the changes needed?

Fix: apache#3206, apache#3203 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
@jerryshao jerryshao merged commit 18ff252 into apache:branch-0.5 May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants