test(pkgJson): make expectations work for npm 5 to 7 #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the following changes in behavior. Saved GitHub URL format in package.json: - npm 6: git+/~https://github.com/apache/cordova-android.git#4.1.x - npm 7: github:apache/cordova-android#4.1.x Empty devDependencies format in package.json: - npm 6: `{}` - npm 7: `undefined`
breautek
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In some cases, npm 7 causes the
package.jsonto look slightly different than with npm 6. This PR changes our tests so that they work with both flavors.Description
This PR addresses the following differences:
Saved GitHub URL format in
package.json:git+/~https://github.com/apache/cordova-android.git#4.1.xgithub:apache/cordova-android#4.1.xEmpty devDependencies format in
package.json:{}undefinedTesting
npm@6npm@^7.2and fix: cordova-fetch with npm@7 cordova-fetch#91Except for one test that fails due to a bug in npm 7: npm v7 does not install linked packages dependencies npm/cli#2339