Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonVirtualenvOperator: termination error message in alert #31747

Merged

Conversation

karunpoudel
Copy link
Contributor

@karunpoudel karunpoudel commented Jun 6, 2023

The error alert email from PythonVirtualenvOperator and ExternalPythonOperator only contain exit status code. It doesn't contain error messages similar to PythonOperator. This change adds the error message on these operators too.

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Jun 6, 2023
@karunpoudel karunpoudel force-pushed the pythonvenv-termination-error-in-alert branch from c5eeb84 to 0818ff7 Compare June 6, 2023 22:28
@karunpoudel karunpoudel changed the title PythonVirtualenvOperator: termination error log in alert PythonVirtualenvOperator: termination error message in alert Jun 6, 2023
@karunpoudel karunpoudel force-pushed the pythonvenv-termination-error-in-alert branch from 8172d90 to e5dd3fe Compare June 7, 2023 00:19
@karunpoudel karunpoudel marked this pull request as ready for review June 7, 2023 00:20
@karunpoudel karunpoudel force-pushed the pythonvenv-termination-error-in-alert branch 2 times, most recently from d3ff257 to 1e75b69 Compare June 7, 2023 18:29
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@potiuk potiuk merged commit 51419a7 into apache:main Jun 7, 2023
@eladkal eladkal added this to the Airflow 2.7.0 milestone Jun 8, 2023
@eladkal eladkal added the type:improvement Changelog: Improvements label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants