apache-superset · zhaoyongjie · Nov 15, 2021 · Nov 12, 2021 · Nov 12, 2021 · Nov 12, 2021
@@ -5,4 +5,4 @@ esm/
 lib/
 tmp/
 dist/
-temporary-plugins/
+temporary-plugins/
@@ -39,6 +39,38 @@ module.exports = {
         extensions: ['.js', '.jsx', '.ts', '.tsx'],
       },
     },
+    // Allow core/src and core/test, not import modules from lib
+    'import/internal-regex': /^@superset-ui\/core\/(src|test)/,
+    'import/core-modules': [
+      '@superset-ui/core',
+      '@superset-ui/chart-controls',
+      '@superset-ui/legacy-plugin-chart-calendar',
+      '@superset-ui/legacy-plugin-chart-chord',
+      '@superset-ui/legacy-plugin-chart-country-map',
+      '@superset-ui/legacy-plugin-chart-event-flow',
+      '@superset-ui/legacy-plugin-chart-force-directed',
+      '@superset-ui/legacy-plugin-chart-heatmap',
+      '@superset-ui/legacy-plugin-chart-histogram',
+      '@superset-ui/legacy-plugin-chart-horizon',
+      '@superset-ui/legacy-plugin-chart-map-box',
+      '@superset-ui/legacy-plugin-chart-paired-t-test',
+      '@superset-ui/legacy-plugin-chart-parallel-coordinates',
+      '@superset-ui/legacy-plugin-chart-partition',
+      '@superset-ui/legacy-plugin-chart-pivot-table',
+      '@superset-ui/legacy-plugin-chart-rose',
+      '@superset-ui/legacy-plugin-chart-sankey',
+      '@superset-ui/legacy-plugin-chart-sankey-loop',
+      '@superset-ui/legacy-plugin-chart-sunburst',
+      '@superset-ui/legacy-plugin-chart-time-table',
+      '@superset-ui/legacy-plugin-chart-treemap',
+      '@superset-ui/legacy-plugin-chart-world-map',
+      '@superset-ui/legacy-preset-chart-big-number',
+      '@superset-ui/legacy-preset-chart-nvd3',
+      '@superset-ui/plugin-chart-echarts',
+      '@superset-ui/plugin-chart-table',
+      '@superset-ui/plugin-chart-word-cloud',
+      '@superset-ui/preset-chart-xy',
+    ],
     react: {
       version: 'detect',
     },
@@ -215,7 +247,13 @@ module.exports = {
       },
     },
     {
-      files: ['*.test.*', './**/test/**/*'],
+      files: [
+        '*.test.ts',
+        '*.test.tsx',
+        '*.test.js',
+        '*.test.jsx',
+        'fixtures.*',
+      ],
       plugins: ['jest', 'jest-dom', 'no-only-tests', 'testing-library'],
       env: {
         'jest/globals': true,

@@ -52,10 +52,10 @@ jobs:
 
       - name: Install dependencies
         run: npm ci
-      - name: Build packages
-        run: npm run build
       - name: Run ESLint
         run: npm run lint --quiet
+      - name: Build packages
+        run: npm run build
       - name: Run unit tests
         run: npm run test
       - name: Build Storybook

@@ -198,4 +198,4 @@ Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
-limitations under the License.
+limitations under the License.
@@ -21,7 +21,7 @@
     "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
     "lint:fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
     "format": "npm run prettier",
-    "prettier": "prettier --write .",
+    "prettier": "prettier --write './{plugins,packages}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}'",
     "test": "npm run jest",
     "test:watch": "npm run lint:fix && npm run jest --watch",
     "type": "npm run build --no-babel",

@@ -51,4 +51,4 @@ Then use it via `SuperChart`. See [storybook](https://apache-superset.github.io/
 │   └── index.test.ts
 └── types
     └── external.d.ts
-```
+```
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -177,7 +177,7 @@ export type TabOverride = 'data' | 'customize' | boolean;
  *    show a warning based on the value of another component. It's also possible to bind
  *    arbitrary data from the redux store to the component this way.
  * - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data`
-     tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL 
+     tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL
      `renderTrigger: true` components will show up on the `Customize` tab.
  * - visibility: a function that uses control panel props to check whether a control should
  *    be visibile.

@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -17,8 +17,12 @@
  * under the License.
  */
 import { AdhocColumn } from '@superset-ui/core';
-import { isAdhocColumn, isColumnMeta, isSavedExpression } from '../src';
-import { ColumnMeta } from '../lib';
+import {
+  isAdhocColumn,
+  isColumnMeta,
+  isSavedExpression,
+  ColumnMeta,
+} from '../src';
 
 const ADHOC_COLUMN: AdhocColumn = {
   hasCustomLabel: true,

@@ -19,4 +19,4 @@
       "path": "../superset-ui-core"
     }
   ]
-}
+}
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -15,4 +15,4 @@
     "../../types/**/*"
   ],
   "references": []
-}
+}
@@ -6,9 +6,9 @@
  * to you under the Apache License, Version 2.0 (the
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
- * 
+ *
  *   http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an
  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY

@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -2,7 +2,8 @@
   "compilerOptions": {
     "declarationDir": "lib",
     "outDir": "lib",
-    "rootDir": "src"
+    "rootDir": "src",
+    "allowJs": false
   },
   "exclude": [
     "lib",
@@ -22,4 +23,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -44,6 +44,8 @@ export { default as TimeseriesTransformProps } from './Timeseries/transformProps
 export { default as TreeTransformProps } from './Tree/transformProps';
 export { default as TreemapTransformProps } from './Treemap/transformProps';
 
+export { DEFAULT_FORM_DATA as TimeseriesDefaultFormData } from './Timeseries/types';
+
 export * from './types';
 
 /**

@@ -19,4 +19,4 @@
       "path": "../../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -22,4 +22,4 @@
       "path": "../../packages/superset-ui-core"
     }
   ]
-}
+}
@@ -18,11 +18,11 @@
  */
 import React from 'react';
 import { CommonWrapper } from 'enzyme';
-import { mount } from '../../../test/enzyme';
 import TableChart from '../src/TableChart';
 import transformProps from '../src/transformProps';
 import DateWithFormatter from '../src/utils/DateWithFormatter';
 import testData from './testData';
+import { mount } from './enzyme';
 
 describe('plugin-chart-table', () => {
   describe('transformProps', () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,4 +5,4 @@ esm/ @@
     lib/
     tmp/
     dist/
-    temporary-plugins/
+    temporary-plugins/