Refactor - Adds CLI parameter "--with-compute-unit-price" to program-v4 #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/cli-program-v4
branch
from
46aa689 to
82f9a8a
Compare
Lichtso
force-pushed
the
refactor/cli-program-v4
branch
from
82f9a8a to
b083bbe
Compare
pgarg66
reviewed
Feb 28, 2025
pgarg66
approved these changes
Feb 28, 2025
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
…v4 (#5086) * Changes underscore to dash for consistency. * Adds helper closure for constructing messages. * Removes the closure parameter from calculate_max_chunk_size(). * Adds "--with-compute-unit-price". * Sends both instructions of process_close_program() in a single transaction. * Factors redundant code into a message_factory(). (cherry picked from commit 62f5b70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Without this parameter dApp devs can not control the priority fees per CU and might have trouble landing deployments on MNB.
Summary of Changes
Adds "--with-compute-unit-price" CLI parameter.