-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial implementations for packet forwarder in vortexor #5027
base: master
Are you sure you want to change the base?
Added initial implementations for packet forwarder in vortexor #5027
Conversation
Oh that looks interesting ! |
Functionally it is equivalent. We target to get this natively supported in Agave and with some performance improvements. |
Makes sense thanks ! Its interesting to see the facturation of the validator stage being made standalone module like this. Just rambling x) |
83f9ed4
to
b0bfc56
Compare
f20f3a4
to
4d500a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see I was added as a reviewer, but I'm not familiar with this part of the code. Is there something specific you'd like me review?
100b3ba
to
dabf02e
Compare
No worry, I saw your name in the suggested reviewers for the changes and blindly clicked it. |
clippy problems enable loggings reverted a change in cargo.toml in streamer log vortexor pubkey in log file
4a04f34
to
3201fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of nitpicks, looking good!
log-utils/Cargo.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add this to solana-logger crate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logger seems to be removed from the mono-repo. also the solana-logger seems to be the setting for the logger itself. This is only used for executables redirecting stderr to log files and a little less generic than the logger functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is in sdk. Just feels wrong to create another crate just for 2 functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe @bw-solana can advise on how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually only one pub functions. But this is not first time we do it. e.g. genesis-utils also has only one pub function in it.
Problem
Added capability in TPU vortexor to forward verified packets to configured validator.
Summary of Changes
Support logging into files in vortexor.
Support specifying pairing validator's addresses
Receive from sigverify and send packets to pairing validators.
This PR will be followed by the receiver side in the validator and stake map updater.
For now run the vortexor like this:
./target/release/solana-vortexor -i /home/solana/.config/solana/id.json -n 10.138.0.136:8100
USAGE:
solana-vortexor --destination HOST:PORT... --identity
Fixes #