Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agave-validator: add args tests for wait-for-restart-window #4902

Merged
merged 7 commits into from
Mar 1, 2025

Conversation

yihau
Copy link
Member

@yihau yihau commented Feb 11, 2025

Problem

#4082

Summary of Changes

  • add COMMAND const
  • extract clap args into a struct
    • impl FromClapArgMatches
    • impl Default
  • add tests

@yihau yihau changed the title agave-validator: add args tests for window agave-validator: add args tests for wait-for-restart-window Feb 11, 2025
@yihau yihau mentioned this pull request Feb 11, 2025
@yihau yihau requested a review from steviez February 12, 2025 05:20
@yihau yihau force-pushed the add-restart-window-test branch from ea744b4 to 778a696 Compare February 14, 2025 11:54
@yihau yihau force-pushed the add-restart-window-test branch from 538f7d6 to 338c71a Compare February 27, 2025 04:19
@yihau yihau requested a review from steviez February 27, 2025 04:31
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized one more thing, LGTM after that

@yihau yihau merged commit 4c12762 into anza-xyz:master Mar 1, 2025
47 checks passed
@yihau yihau deleted the add-restart-window-test branch March 1, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants