Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agave-validator: extract exit #4771

Merged
merged 2 commits into from
Feb 4, 2025
Merged

agave-validator: extract exit #4771

merged 2 commits into from
Feb 4, 2025

Conversation

yihau
Copy link
Member

@yihau yihau commented Feb 4, 2025

Problem

#4082

Summary of Changes

extract exit

@yihau yihau marked this pull request as ready for review February 4, 2025 03:30
@yihau yihau requested a review from steviez February 4, 2025 03:30
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, only reviewed the last commit as I know the first 3 are part of another review

steviez
steviez previously approved these changes Feb 4, 2025
@yihau yihau mentioned this pull request Feb 4, 2025
@yihau yihau dismissed steviez’s stale review February 4, 2025 04:18

The merge-base changed after approval.

Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the rebase

@yihau yihau merged commit d75c73c into anza-xyz:master Feb 4, 2025
47 checks passed
@yihau yihau deleted the extract-exit branch February 4, 2025 09:50
@yihau yihau mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants