Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4886: add joinSpace param in PublishState pb model #2025

Merged

Conversation

AnastasiaShemyakinskaya
Copy link
Member

  1. Save joinSpace in Version field for server
  2. Add new parameter in middleware pb model PublishingState
  3. Retrieve joinSpace parameter from version and save it in pb model for client

Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Copy link

github-actions bot commented Jan 20, 2025

Previous Coverage 50.6% of statements
New Coverage 50.6% of statements
Patch Coverage 80.0% of changed statements (16/20)

Coverage provided by /~https://github.com/seriousben/go-patch-cover-action

Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya merged commit 08c2a20 into main Jan 21, 2025
5 checks passed
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya deleted the go-4886-add-joinspace-param-in-publish-version branch January 21, 2025 10:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants