Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4840 Check keys to unset from StructDiff #2017

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

KirillSto
Copy link
Member

https://linear.app/anytype/issue/GO-4840/set-null-detail-on-objectrelationadd

Check detail keys that are going to be removed. If struct diff is nil, while the list is not empty, we still need to generate event messages

@KirillSto KirillSto self-assigned this Jan 16, 2025
@KirillSto KirillSto requested a review from deff7 January 16, 2025 17:25
Copy link

Previous Coverage 50.6% of statements
New Coverage 50.6% of statements
Patch Coverage 75.0% of changed statements (6/8)

Coverage provided by /~https://github.com/seriousben/go-patch-cover-action

@KirillSto KirillSto merged commit 878964d into main Jan 16, 2025
5 checks passed
@KirillSto KirillSto deleted the go-4840-check-keys-to-unset branch January 16, 2025 23:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants