Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4865 | GO-4617 | GO-4866 | GO-4758 | GO-4851: web publishing fixes #2014

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

AnastasiaShemyakinskaya
Copy link
Member

  1. Fixed url for members
    func (s *service) makeUrl(uri, identity, globalName string) string {
  2. Added Unpublish method
    func (s *service) Unpublish(ctx context.Context, spaceId, pageObjId string) error {
  3. Save invite link in snapshot if toggle is on, space is shared and invite link is present in view
    func (s *service) extractInviteLink(ctx context.Context, spaceId string, joinSpace, isPersonal bool) (string, error) {
  4. Evaluate limits for members and non-members
    func (s *service) getPublishLimit(globalName string) (int64, error) {
  5. Add real version for publising
    func (s *service) evaluateDocumentVersion(spc clientspace.Space, pageId string) (string, error) {

Additional improvements

  1. Separate function publishToPublishServer into separate calls to remove linter errors
  2. Remove not needed logs
  3. Remove stubs and call real publish api server
  4. Added tests for Publish function
  5. Remove not needed functions

Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Copy link

github-actions bot commented Jan 16, 2025

New Coverage 50.6% of statements
Patch Coverage 57.2% of changed statements (95/166)

Coverage provided by /~https://github.com/seriousben/go-patch-cover-action

Copy link
Contributor

@zarkone zarkone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya merged commit 63d784a into GO-4140-publish-2 Jan 17, 2025
5 checks passed
@AnastasiaShemyakinskaya AnastasiaShemyakinskaya deleted the GO-4140-fix-middle-issues branch January 17, 2025 11:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants