Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-3849 Do not GC set if source is set #1524

Merged
merged 1 commit into from
Aug 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/block/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,13 @@ func (s *Service) SetSource(ctx session.Context, req pb.RpcObjectSetSourceReques
return true
})
st.SetDetailAndBundledRelation(bundle.RelationKeySetOf, pbtypes.StringList(req.Source))
return sb.Apply(st, smartblock.NoRestrictions)

flags := internalflag.NewFromState(st)
// set with source is no longer empty
flags.Remove(model.InternalFlag_editorDeleteEmpty)
flags.AddToState(st)

return sb.Apply(st, smartblock.NoRestrictions, smartblock.KeepInternalFlags)
})
}

Expand Down
Loading