GO-3981 zip tracing on android is slow

core/application/account_select.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"os"
 	"path/filepath"
+	"runtime"
 	trace2 "runtime/trace"
 	"strings"
 
@@ -40,9 +41,10 @@ func (s *Service) AccountSelect(ctx context.Context, req *pb.RpcAccountSelectReq
 		return nil, ErrEmptyAccountID
 	}
 
-	s.traceRecorder.start()
-	defer s.traceRecorder.stop()
-
+	if runtime.GOOS != "android" && runtime.GOOS != "ios" {
+		s.traceRecorder.start()
+		defer s.traceRecorder.stop()
+	}
 	s.cancelStartIfInProcess()
 	s.lock.Lock()
 	defer s.lock.Unlock()

core/application/profiler.go

@@ -13,6 +13,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/klauspost/compress/flate"
 	exptrace "golang.org/x/exp/trace"
 
 	"github.com/anyproto/anytype-heart/util/debug"
@@ -91,6 +92,9 @@ type zipFile struct {
 
 func createZipArchive(w io.Writer, files []zipFile) error {
 	zipw := zip.NewWriter(w)
+	zipw.RegisterCompressor(zip.Deflate, func(w io.Writer) (io.WriteCloser, error) {
+		return flate.NewWriter(w, flate.BestSpeed)
+	})
 	err := func() error {
 		for _, file := range files {
 			f, err := zipw.Create(file.name)
@@ -107,8 +111,8 @@ func createZipArchive(w io.Writer, files []zipFile) error {
 	return errors.Join(err, zipw.Close())
 }
 
-func (s *Service) SaveLoginTrace() (string, error) {
-	return s.traceRecorder.save()
+func (s *Service) SaveLoginTrace(dir string) (string, error) {
+	return s.traceRecorder.save(dir)
 }
 
 // traceRecorder is a helper to start and stop flight trace recorder
@@ -118,7 +122,8 @@ type traceRecorder struct {
 	lastRecordedBuf *bytes.Buffer // contains zip archive of trace
 }
 
-func (r *traceRecorder) save() (string, error) {
+// empty dir means use system temp dir
+func (r *traceRecorder) save(dir string) (string, error) {
 	r.lock.Lock()
 	defer r.lock.Unlock()
 
@@ -138,7 +143,7 @@ func (r *traceRecorder) save() (string, error) {
 		traceReader = buf
 	}
 
-	f, err := os.CreateTemp("", "account-select-trace-*.zip")
+	f, err := os.CreateTemp(dir, "account-select-trace-*.zip")
 	if err != nil {
 		return "", fmt.Errorf("create temp file: %w", err)
 	}

core/debug.go

@@ -224,7 +224,7 @@ func (mw *Middleware) DebugRunProfiler(cctx context.Context, req *pb.RpcDebugRun
 }
 
 func (mw *Middleware) DebugAccountSelectTrace(cctx context.Context, req *pb.RpcDebugAccountSelectTraceRequest) *pb.RpcDebugAccountSelectTraceResponse {
-	path, err := mw.applicationService.SaveLoginTrace()
+	path, err := mw.applicationService.SaveLoginTrace(req.Dir)
 	if err != nil {
 		return &pb.RpcDebugAccountSelectTraceResponse{
 			Error: &pb.RpcDebugAccountSelectTraceResponseError{

core/files/fileobject/service_test.go

@@ -29,6 +29,7 @@ import (
 	"github.com/anyproto/anytype-heart/core/filestorage"
 	"github.com/anyproto/anytype-heart/core/filestorage/filesync"
 	"github.com/anyproto/anytype-heart/core/filestorage/rpcstore"
+	"github.com/anyproto/anytype-heart/core/session"
 	wallet2 "github.com/anyproto/anytype-heart/core/wallet"
 	"github.com/anyproto/anytype-heart/core/wallet/mock_wallet"
 	"github.com/anyproto/anytype-heart/pb"
@@ -68,6 +69,16 @@ func (c *dummyConfig) Name() string {
 	return "dummyConfig"
 }
 
+type dummyObjectArchiver struct{}
+
+func (a *dummyObjectArchiver) SetPagesIsArchived(ctx session.Context, req pb.RpcObjectListSetIsArchivedRequest) error {
+	return nil
+}
+
+func (a *dummyObjectArchiver) Name() string { return "dummyObjectArchiver" }
+
+func (a *dummyObjectArchiver) Init(_ *app.App) error { return nil }
+
 const testResolveRetryDelay = 5 * time.Millisecond
 
 func newFixture(t *testing.T) *fixture {
@@ -85,6 +96,7 @@ func newFixture(t *testing.T) *fixture {
 	eventSender.EXPECT().Broadcast(mock.Anything).Return().Maybe()
 	fileService := files.New()
 	spaceService := mock_space.NewMockService(t)
+	spaceService.EXPECT().GetPersonalSpace(mock.Anything).Return(nil, fmt.Errorf("not needed")).Maybe()
 	spaceIdResolver := mock_idresolver.NewMockResolver(t)
 
 	svc := New(testResolveRetryDelay, testResolveRetryDelay)
@@ -114,6 +126,7 @@ func newFixture(t *testing.T) *fixture {
 	a.Register(testutil.PrepareMock(ctx, a, mock_accountservice.NewMockService(ctrl)))
 	a.Register(testutil.PrepareMock(ctx, a, wallet))
 	a.Register(&config.Config{DisableFileConfig: true, NetworkMode: pb.RpcAccount_DefaultConfig, PeferYamuxTransport: true})
+	a.Register(&dummyObjectArchiver{})
 
 	err = a.Start(ctx)
 	require.NoError(t, err)

core/peerstatus/status_test.go

@@ -203,10 +203,6 @@ func TestP2pStatus_SendPeerUpdate(t *testing.T) {
 		f.setNotPossibleStatus()
 		checkStatus(t, "spaceId", f.p2pStatus, NotPossible)
 
-		f.store.UpdateLocalPeer("peerId", []string{"spaceId"})
-		ctrl := gomock.NewController(t)
-		peer := mock_peer.NewMockPeer(ctrl)
-		peer.EXPECT().Id().Return("peerId")
 		f.sender.EXPECT().Broadcast(&pb.Event{
 			Messages: []*pb.EventMessage{
 				{
@@ -220,6 +216,10 @@ func TestP2pStatus_SendPeerUpdate(t *testing.T) {
 				},
 			},
 		})
+		f.store.UpdateLocalPeer("peerId", []string{"spaceId"})
+		ctrl := gomock.NewController(t)
+		peer := mock_peer.NewMockPeer(ctrl)
+		peer.EXPECT().Id().Return("peerId")
 		err := f.pool.AddPeer(context.Background(), peer)
 		assert.Nil(t, err)
 
@@ -234,13 +234,6 @@ func TestP2pStatus_SendPeerUpdate(t *testing.T) {
 		// when
 		checkStatus(t, "spaceId", f.p2pStatus, NotConnected)
 
-		f.store.UpdateLocalPeer("peerId", []string{"spaceId"})
-		ctrl := gomock.NewController(t)
-		peer := mock_peer.NewMockPeer(ctrl)
-		peer.EXPECT().Id().Return("peerId")
-		err := f.pool.AddPeer(context.Background(), peer)
-		assert.Nil(t, err)
-
 		f.sender.EXPECT().Broadcast(&pb.Event{
 			Messages: []*pb.EventMessage{
 				{
@@ -254,6 +247,13 @@ func TestP2pStatus_SendPeerUpdate(t *testing.T) {
 				},
 			},
 		})
+		f.store.UpdateLocalPeer("peerId", []string{"spaceId"})
+		ctrl := gomock.NewController(t)
+		peer := mock_peer.NewMockPeer(ctrl)
+		peer.EXPECT().Id().Return("peerId")
+		err := f.pool.AddPeer(context.Background(), peer)
+		assert.Nil(t, err)
+
 		checkStatus(t, "spaceId", f.p2pStatus, Connected)
 
 		// then

docs/proto.md

@@ -9732,6 +9732,11 @@ Get marks list in the selected range in text block.
 
 
 
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| dir | [string](#string) |  | empty means using OS-provided temp dir |
+
+