Merge pull request #1671 from anyproto/go-4243-app-close-many-spaces

GO-4243 app close many spaces
anyproto · Oct 14, 2024 · e33a1e2 · e33a1e2
2 parents 8418e48 + c9897e8
commit e33a1e2
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/space/service.go b/space/service.go
@@ -442,12 +442,18 @@ func (s *service) Close(ctx context.Context) error {
 	}
 	s.mu.Unlock()
 
+	wg := sync.WaitGroup{}
 	for _, ctrl := range ctrls {
-		err := ctrl.Close(ctx)
-		if err != nil {
-			log.Error("close space", zap.String("spaceId", ctrl.SpaceId()), zap.Error(err))
-		}
+		wg.Add(1)
+		go func(ctrl spacecontroller.SpaceController) {
+			defer wg.Done()
+			err := ctrl.Close(ctx)
+			if err != nil {
+				log.Error("close space", zap.String("spaceId", ctrl.SpaceId()), zap.Error(err))
+			}
+		}(ctrl)
 	}
+	wg.Wait()
 	err := s.techSpace.Close(ctx)
 	if err != nil {
 		log.Error("close tech space", zap.Error(err))