Skip to content
This repository has been archived by the owner on Sep 16, 2020. It is now read-only.

Fix 'Found more than one unified job' bug #721

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

MarBra
Copy link
Contributor

@MarBra MarBra commented Jul 17, 2019

Hi :)

the send command can't find the right job, if you setup a job and a workflow with the same name.

Steps to reproduce:

  • Create job a
  • Create workflow a
  • Create workflow b
    • Include Job a

tower-cli receive --workflow b > b.json
tower-cli send b.json

Cheers
Marcel

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.393% when pulling 8bf16ea on MarBra:master into 8a020e8 on ansible:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.393% when pulling 8bf16ea on MarBra:master into 8a020e8 on ansible:master.

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with using that query filter, and think this should be an open-and-shut fix. @john-westcott-iv any objections? Making it exactly equal to the job type should also work fine.

@john-westcott-iv
Copy link
Member

If we set it starts_with and there is another job_type_x added later that will pick it up instead of not finding those if we do an exact match. So I am good to merge this in. Thanks @MarBra for the fix!

@AlanCoding AlanCoding added this to the release_3.3.5 milestone Jul 18, 2019
@AlanCoding AlanCoding merged commit 03e0b13 into ansible:master Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants