Skip to content
This repository has been archived by the owner on Sep 16, 2020. It is now read-only.

enable notifier on org, project and inventory sources #700

Merged
merged 2 commits into from
Jul 9, 2019
Merged

enable notifier on org, project and inventory sources #700

merged 2 commits into from
Jul 9, 2019

Conversation

jainnikhil30
Copy link
Contributor

fixes #595

@jainnikhil30 jainnikhil30 requested a review from AlanCoding April 26, 2019 13:39
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.434% when pulling 410edf0 on jainnikhil30:master into a2b151f on ansible:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.434% when pulling 410edf0 on jainnikhil30:master into a2b151f on ansible:master.

AlanCoding
AlanCoding approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not like the duplication, but when I dug in it was painfully clear why it was that way to begin with, and your change maintains the pattern well, as far as I can tell.

@AlanCoding AlanCoding merged commit 8a020e8 into ansible:master Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable notifier on org or project level with tower-cli
3 participants
@jainnikhil30 @coveralls @AlanCoding