Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and Issue fixes #20

Merged
merged 24 commits into from
May 26, 2021
Merged

Linting and Issue fixes #20

merged 24 commits into from
May 26, 2021

Conversation

georgenalen
Copy link
Contributor

Issue Fixes:
#5 - 9.1.4/9.2.4/9.3.4 - Wrong data value
#6 - 2.3.11.4 - Wrong data value
#7 - 18.9.95.1 - Wrong data value
#8 - 18.9.26..1 - Wrong data type
#9 - 18.4.1 - Wrong data type
#10 - 18.3.4 - Wrong data value
#11 - 19.7.4.1 - Wrong data value
#12 - 2.3.17.3 - Wrong data value
#13 - 2.3.6.4 - Wrong data value
#14 - 19.7.41.1 - Bad tag
#16 - 2.3.1.5/2.3.1.6 - Hardcoded values instead of variables

Enhancements:

  • Updated README
  • Updated CONTRIBUTING
  • Adding linting files .ansible-lint and .yamllint
  • Fixed linting issues

georgenalen and others added 20 commits April 28, 2021 12:39
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Updated README, Contributing, and added variables to section 18
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
@georgenalen georgenalen requested a review from uk-bolly May 26, 2021 12:21
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
uk-bolly
uk-bolly previously approved these changes May 26, 2021
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for changes

removed .cache folder and updated .gitignore
uk-bolly
uk-bolly previously approved these changes May 26, 2021
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

georgenalen and others added 2 commits May 26, 2021 11:02
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches meta requirement

@uk-bolly uk-bolly merged commit 7f75b72 into main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants