-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting and Issue fixes #20
Conversation
April 28 issue fixes
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Updated linting and meta file
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Updated README, Contributing, and added variables to section 18 Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for changes
removed .cache folder and updated .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
updated meta platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matches meta requirement
Issue Fixes:
#5 - 9.1.4/9.2.4/9.3.4 - Wrong data value
#6 - 2.3.11.4 - Wrong data value
#7 - 18.9.95.1 - Wrong data value
#8 - 18.9.26..1 - Wrong data type
#9 - 18.4.1 - Wrong data type
#10 - 18.3.4 - Wrong data value
#11 - 19.7.4.1 - Wrong data value
#12 - 2.3.17.3 - Wrong data value
#13 - 2.3.6.4 - Wrong data value
#14 - 19.7.41.1 - Bad tag
#16 - 2.3.1.5/2.3.1.6 - Hardcoded values instead of variables
Enhancements: