WIP: Start testing network-ee

This starts the process of moving our testing to be based on execution environments. Depends-On: ansible/ansible-zuul-jobs#742 Depends-On: ansible/network-ee#27 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
ansible-collections · Jan 20, 2021 · 7cded6a · 7cded6a
1 parent ce92477
commit 7cded6a
Show file tree

Hide file tree

Showing 9 changed files with 35 additions and 13 deletions.
diff --git a/.zuul.yaml b/.zuul.yaml
@@ -0,0 +1,5 @@
+---
+- project:
+    templates:
+      - network-ee-container-image-jobs
+      - network-ee-tests
diff --git a/plugins/module_utils/network/eos/argspec/acls/acls.py b/plugins/module_utils/network/eos/argspec/acls/acls.py
@@ -387,7 +387,11 @@ def __init__(self, **kwargs):
                             "type": "list",
                         },
                         "name": {"required": True, "type": "str"},
-                        "standard": {"type": "bool"},
+                        "standard": {
+                            "default": False,
+                            "required": False,
+                            "type": "bool",
+                        },
                     },
                     "type": "list",
                 },

diff --git a/plugins/module_utils/network/eos/argspec/l3_interfaces/l3_interfaces.py b/plugins/module_utils/network/eos/argspec/l3_interfaces/l3_interfaces.py
@@ -46,7 +46,7 @@ def __init__(self, **kwargs):
                     "elements": "dict",
                     "options": {
                         "address": {"type": "str"},
-                        "secondary": {"type": "bool"},
+                        "secondary": {"default": False, "type": "bool"},
                     },
                     "type": "list",
                 },

diff --git a/plugins/module_utils/network/eos/argspec/ospf_interfaces/ospf_interfaces.py b/plugins/module_utils/network/eos/argspec/ospf_interfaces/ospf_interfaces.py
@@ -56,7 +56,7 @@ def __init__(self, **kwargs):
             "elements": "dict",
             "type": "list",
             "options": {
-                "name": {"type": "str"},
+                "name": {"required": True, "type": "str"},
                 "address_family": {
                     "elements": "dict",
                     "type": "list",

diff --git a/plugins/module_utils/network/eos/eos.py b/plugins/module_utils/network/eos/eos.py
@@ -60,7 +60,9 @@
         fallback=(env_fallback, ["ANSIBLE_NET_SSH_KEYFILE"]), type="path"
     ),
     "authorize": dict(
-        fallback=(env_fallback, ["ANSIBLE_NET_AUTHORIZE"]), type="bool"
+        default=False,
+        fallback=(env_fallback, ["ANSIBLE_NET_AUTHORIZE"]),
+        type="bool",
     ),
     "auth_pass": dict(
         no_log=True, fallback=(env_fallback, ["ANSIBLE_NET_AUTH_PASS"])

diff --git a/plugins/modules/eos_eapi.py b/plugins/modules/eos_eapi.py
@@ -397,13 +397,15 @@ def main():
     """ main entry point for module execution
     """
     argument_spec = dict(
-        http=dict(aliases=["enable_http"], type="bool"),
+        http=dict(aliases=["enable_http"], default=False, type="bool"),
         http_port=dict(type="int"),
         https=dict(aliases=["enable_https"], type="bool"),
         https_port=dict(type="int"),
-        local_http=dict(aliases=["enable_local_http"], type="bool"),
+        local_http=dict(
+            aliases=["enable_local_http"], default=False, type="bool"
+        ),
         local_http_port=dict(type="int"),
-        socket=dict(aliases=["enable_socket"], type="bool"),
+        socket=dict(aliases=["enable_socket"], default=False, type="bool"),
         timeout=dict(type="int", default=30),
         vrf=dict(default="default"),
         config=dict(),

diff --git a/plugins/modules/eos_l3_interface.py b/plugins/modules/eos_l3_interface.py
@@ -111,14 +111,20 @@
 - name: Set IP addresses on aggregate
   arista.eos.eos_l3_interface:
     aggregate:
-    - {name: ethernet1, ipv4: 192.168.2.10/24}
-    - {name: ethernet1, ipv4: 192.168.3.10/24, ipv6: fd5d:12c9:2201:1::1/64}
+    - name: ethernet1
+      ipv4: 192.168.2.10/24
+    - name: ethernet1
+      ipv4: 192.168.3.10/24
+      ipv6: fd5d:12c9:2201:1::1/64
 
 - name: Remove IP addresses on aggregate
   arista.eos.eos_l3_interface:
     aggregate:
-    - {name: ethernet1, ipv4: 192.168.2.10/24}
-    - {name: ethernet1, ipv4: 192.168.3.10/24, ipv6: fd5d:12c9:2201:1::1/64}
+    - name: ethernet1
+      ipv4: 192.168.2.10/24
+    - name: ethernet1
+      ipv4: 192.168.3.10/24
+      ipv6: fd5d:12c9:2201:1::1/64
     state: absent
 """
 

diff --git a/plugins/modules/eos_vrf.py b/plugins/modules/eos_vrf.py
@@ -139,8 +139,10 @@
 - name: Create aggregate of VRFs with purge
   arista.eos.eos_vrf:
     aggregate:
-    - {name: test4, rd: 1:204}
-    - {name: test5, rd: 1:205}
+    - name: test4
+      rd: 1:204
+    - name: test5
+      rd: 1:205
     state: present
     purge: yes
 

diff --git a/tests/sanity/ignore-2.11.txt b/tests/sanity/ignore-2.11.txt
@@ -0,0 +1 @@
+plugins/action/eos.py action-plugin-docs # base class for deprecated network platform modules using `connection: local`
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		plugins/action/eos.py action-plugin-docs # base class for deprecated network platform modules using `connection: local`