WIP: #13 Unifying MASP implementations between CLI and Web #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
deleted the
feat/13_unify_masp_implementations_between_cli_and_web
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
It unifies the implementation of creating MASP transfers between CLI and Web client. The code in core
namada/sharedis refactored so that the only aspects that are different between those are contained in a trait calledShieldedUtilsand are being implemented and passed to a common code.The changes here are reflecting the refactoring that is being done at the core Namada codebase here anoma/namada#848
How to test it
The instructions will follow soon