Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT SUBMIT: Test another pr 4 #40229

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DO NOT SUBMIT: Test another pr 4 #40229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3cc4bd6
unskip carousel e2e tests
erwinmombay Jan 13, 2025
69b6323
remove failing tests on CI
erwinmombay Jan 13, 2025
0780d76
DO NOT SUBMIT
erwinmombay Jan 14, 2025
53841ce
add another set again to see if it passes in CI
erwinmombay Jan 14, 2025
6d050db
force a single test on CI since it is passing locally
erwinmombay Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build-system/tasks/e2e/selenium-webdriver-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,14 @@ class SeleniumWebDriverController {
]);
const resultWidth = Number(updatedHtmlElementSizes[0]);
const resultHeight = Number(updatedHtmlElementSizes[1]);

await this.driver
.manage()
.window()
.setRect({
width: width + horizBorder,
height: height + vertBorder,
});
// TODO(sparhami) These are throwing errors, but are not causing the test
// to fail immediately,.Figure out why, we want the test to fail here
// instead of continuing.
Expand Down
2 changes: 1 addition & 1 deletion extensions/amp-base-carousel/0.1/test-e2e/test-arrows-non-looping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describes.endtoend(
});

// TODO(#40214): fix flaky test.
it.skip('should have the arrows in the correct initial state', async () => {
it.only('should have the arrows in the correct initial state', async () => {
await expect(css(prevArrow, 'opacity')).to.equal('0');
await expect(css(nextArrow, 'opacity')).to.equal('1');
});
Expand Down
Loading