fix(server) HEVC black screen on some linux config #2203
Conversation
|
So, from what I understand, the gop_frame is the frequency of intra_frame sending. I guess we have a very large number as it is not very usefull in the context of ALVR. |
|
May I ask what distro? |
|
I am on arch |
|
Tbh I don't understand why it's that ridiculously high anyways |
|
Because we want to insert idrs/I frames when we want to not at the end of gop so higher sized gop means less "unexpected" idr/I frames |
|
Ik, but int max is still ridiculous |
|
Would this insert I frames or IDR frames? Because if it's I frames I see no issue with possibly wrongly inserting one every ~4 minutes at 120 fps |
|
May I ask if you have any news here ? Newbie question : you that "I" frames were ok, so I guess that IDR are not. What is the different between the two and how do they impact with alvr ? |
|
I frames are frames that aren't encoded as differences to previous frames. IDR frames do this but also don't allow any frames before the I frame to be referenced. This will cause pixelated frames because without all the encoding tricks only a pixelated frame can satisfy the bitrate requirements for an IDR frame. |
|
Make it conditional for HEVC and it's fine. Weird workaround is way better than not working at all |
|
I would add, the workaround should be documented with a comment explaining the reasons behind it. |
|
updated |
|
Needs rebasing |
* Increase maximum resolution from 4096 to 8192 * decimal instead of hex * chore: add formatting style for c++ * chore: reformat c++ to new style * chore: add c++ autoformatter * chore: Add missed/bugfixed format changes * fix: routing assumption basis of microphone loopback detection (alvr-org#2209) * fix(server) HEVC black screen on some linux config (alvr-org#2203) * refactor(xtask): ♻️ Fix clippy and refactor (alvr-org#2213) * fix(client_core): 🐛 Fix USB mode (alvr-org#2214) * refactor(client): ♻️ Remove separate Pico Neo 3 Link platform * client gfx refactor (7): partially port lobby * feat(client): ✨ Show hands in lobby * feat(client_openxr): ✨ Make lobby use max swapchain res (alvr-org#2220) * feat(client_core): ✨ Thicken lobby grid lines * fix(client): 🐛 Fix performance regressions on Quest 1 --------- Co-authored-by: shinyquagsire23 <mtinc2@gmail.com> Co-authored-by: Leonhard Saam <leonhard.saam@yahoo.com> Co-authored-by: 瑄 <shanboxuan@gmail.com> Co-authored-by: Nibor62 <Nibor62@users.noreply.github.com> Co-authored-by: zarik5 <riccardo.zaglia5@gmail.com>
Fix for #2202
After a bit of bisection, I found out that reverting this line fixed the blackscreen issue on my config.
WARN: even though I found that it fixes the issue I do not precisely understand why it does so.