Exclude Mime::Type::InvalidMimeType exception
#137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading `frontend` to rails 6, we started seeing this error: `Mime::Type::InvalidMimeType "charset=utf-8" is not a valid MIME type` Example here: https://sentry.io/organizations/govuk/issues/1549200925/?end=2020-03-06T12%3A00%3A23&environment=staging&project=202225&query=is%3Aunresolved+url%3Ahttps%3A%2F%2Fwww-origin.staging.govuk.digital%2Freport-an-unregistered-trader-or-business&start=2020-03-05T16%3A07%3A23&utc=true This is because, even though these errors are rescued by ActionDispatch, they still reach Sentry. Here's the explanation from Sentry's docs: > Rails catches exceptions in the ActionDispatch::ShowExceptions or > ActionDispatch::DebugExceptions middlewares, depending on the > environment. When rails_report_rescued_exceptions is true (it is by > default), Raven will report exceptions even when they are rescued by > these middlewares. So, in order to stop this behaviour, we set this option to be false for `frontend` in this PR: alphagov/frontend#2264 We also want to explicitly add `Mime::Type::InvalidMimeType` to the list of excluded exceptions, hence this PR. Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6
AlanGabbianelli
force-pushed
the
exclude-InvalidMimeType-exception
branch
from
c75fb5f to
4d0ff69
Compare
AlanGabbianelli
pushed a commit
to alphagov/frontend
that referenced
this pull request
Mar 6, 2020
After upgrading to rails 6, we started seeing this error: `Mime::Type::InvalidMimeType "charset=utf-8" is not a valid MIME type` Example here: https://sentry.io/organizations/govuk/issues/1549200925/?end=2020-03-06T12%3A00%3A23&environment=staging&project=202225&query=is%3Aunresolved+url%3Ahttps%3A%2F%2Fwww-origin.staging.govuk.digital%2Freport-an-unregistered-trader-or-business&start=2020-03-05T16%3A07%3A23&utc=true This is because, even though these errors are rescued by ActionDispatch, they still reach Sentry. Here's the explanation from Sentry's docs: > Rails catches exceptions in the ActionDispatch::ShowExceptions or > ActionDispatch::DebugExceptions middlewares, depending on the > environment. When rails_report_rescued_exceptions is true (it is by > default), Raven will report exceptions even when they are rescued by > these middlewares. So, in order to stop this behaviour, we can set this option to be false. Related PRs: - alphagov/email-alert-api#1138 - alphagov/govuk_app_config#137 Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6
AlanGabbianelli
pushed a commit
that referenced
this pull request
Mar 9, 2020
TL;DR: This stops exceptions rescued by rails from appearing in Sentry. After upgrading `frontend` to rails 6, we started seeing this error: `Mime::Type::InvalidMimeType "charset=utf-8" is not a valid MIME type` Example here: sentry.io/organizations/govuk/issues/1549200925/?end=2020-03-06T12%3A00%3A23&environment=staging&project=202225&query=is%3Aunresolved+url%3Ahttps%3A%2F%2Fwww-origin.staging.govuk.digital%2Freport-an-unregistered-trader-or-business&start=2020-03-05T16%3A07%3A23&utc=true This is because, even though these errors are rescued by ActionDispatch, they still reach Sentry. Here's the explanation from Sentry's docs: > Rails catches exceptions in the ActionDispatch::ShowExceptions or > ActionDispatch::DebugExceptions middlewares, depending on the > environment. When rails_report_rescued_exceptions is true (it is by > default), Raven will report exceptions even when they are rescued by > these middlewares. So, in order to stop this behaviour, we initially took a double approach: - set that option to be false for `frontend` in [this PR](alphagov/frontend#2264) to stop all exceptions rescued by rails (not only `Mime::Type::InvalidMimeType`) from appearing in Sentry for `frontend` - explicitly added `Mime::Type::InvalidMimeType` to the list of excluded exceptions in [this PR](#137) to stop `Mime::Type::InvalidMimeType` from appearing in Sentry for all apps that depend on `govuk_app_config` Setting `rails_report_rescued_exceptions` to `false` here is better because it will apply this config to all apps that depend on `govuk_app_config`, making the two PRs above redundant and saving us from making this change in every app. Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6
AlanGabbianelli
pushed a commit
that referenced
this pull request
Mar 9, 2020
TL;DR: This stops exceptions rescued by rails from appearing in Sentry. After upgrading `frontend` to rails 6, we started seeing this error: `Mime::Type::InvalidMimeType "charset=utf-8" is not a valid MIME type` Example here: https://www.sentry.io/organizations/govuk/issues/1549200925/?end=2020-03-06T12%3A00%3A23&environment=staging&project=202225&query=is%3Aunresolved+url%3Ahttps%3A%2F%2Fwww-origin.staging.govuk.digital%2Freport-an-unregistered-trader-or-business&start=2020-03-05T16%3A07%3A23&utc=true This is because, even though these errors are rescued by ActionDispatch, they still reach Sentry. Here's the explanation from Sentry's docs: > Rails catches exceptions in the ActionDispatch::ShowExceptions or > ActionDispatch::DebugExceptions middlewares, depending on the > environment. When rails_report_rescued_exceptions is true (it is by > default), Raven will report exceptions even when they are rescued by > these middlewares. So, in order to stop this behaviour, we initially took a double approach: - set that option to be false for `frontend` in [this PR](alphagov/frontend#2264) to stop all exceptions rescued by rails (not only `Mime::Type::InvalidMimeType`) from appearing in Sentry for `frontend` - explicitly added `Mime::Type::InvalidMimeType` to the list of excluded exceptions in [this PR](#137) to stop `Mime::Type::InvalidMimeType` from appearing in Sentry for all apps that depend on `govuk_app_config` Setting `rails_report_rescued_exceptions` to `false` here is better because it will apply this config to all apps that depend on `govuk_app_config`, making the two PRs above redundant and saving us from making this change in every app. Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6
|
Closing this in favour of #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading
frontendto rails 6, we started seeing this error:Mime::Type::InvalidMimeType "charset=utf-8" is not a valid MIME typeExample here:
https://sentry.io/organizations/govuk/issues/1549200925/?end=2020-03-06T12%3A00%3A23&environment=staging&project=202225&query=is%3Aunresolved+url%3Ahttps%3A%2F%2Fwww-origin.staging.govuk.digital%2Freport-an-unregistered-trader-or-business&start=2020-03-05T16%3A07%3A23&utc=true
This is because, even though these errors are rescued by ActionDispatch,
they still reach Sentry. Here's the explanation from Sentry's docs:
So, in order to stop this behaviour, we set this option to be false for
frontendin this PR: alphagov/frontend#2264We also want to explicitly add
Mime::Type::InvalidMimeTypeto the listof excluded exceptions, hence this PR.
Trello card: https://trello.com/c/Ik7ulDXQ/1768-3-upgrade-frontend-to-rails-6