Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks 968-969 : Xcopa #358

Merged
merged 17 commits into from
Oct 29, 2021
Merged

Tasks 968-969 : Xcopa #358

merged 17 commits into from
Oct 29, 2021

Conversation

amirrezamirzaei
Copy link
Contributor

creating two task from Xcopa
they are the same tasks as in copa but in Estonian. this dataset also contains 10 more languages.
submitting this as a test to see whether we want these kinda task or not. each language contains 600 instances. should I make the other language tasks?

@danyaljj
Copy link
Contributor

danyaljj commented Oct 4, 2021

@Ravsehajsinghpuri wondering if you can review this PR?

{
"input": "Ese oli mullikilesse mässitud.\n(1)See oli õrn.(2)See oli väike.",
"output": "1",
"explanation": "The first alternative makes more sense because you put object is bubble wrap if they are delicate."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant "put object in bubble wrap"

{
"input": "Ma tühjendasin oma taskud.\n(1)Ma leidsin pileti tüki.(2)Ma leidsin relva.",
"output": "1",
"explanation": "The second alternative makes more sense because finding a ticket in your pocket is more common than finding a gun."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is "1" but in the explanation you have mentioned "The second alternative makes more sense"

"explanation": "The second alternative makes more sense because the termites will eat wood."
}
],
"Negative Examples": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one more negative example?

@Ravsehajsinghpuri
Copy link
Contributor

@Ravsehajsinghpuri wondering if you can review this PR?

sure!

@Ravsehajsinghpuri
Copy link
Contributor

Ravsehajsinghpuri commented Oct 12, 2021

@amirrezamirzaei Can you update the "Input language" from et to Estonian and similarly for en to English for all the tasks? Similarly for "Output language" and "Instruction language". I think full form of the language is more appropriate.

@Ravsehajsinghpuri
Copy link
Contributor

This PR is good to go when these minor changes are made. Rest all lgtm

@Ravsehajsinghpuri
Copy link
Contributor

This PR lgtm @danyaljj

@danyaljj
Copy link
Contributor

Please make sure to set the "Categories": [""] and "Domains": [""] fields according to the taxonomy presented here.

@amirrezamirzaei
Copy link
Contributor Author

@danyaljj I'm not sure what the appropriate domain is in these two tasks. the instances don't seem to be about anything particular.

@Palipoor
Copy link
Contributor

Hi! I think according to the paper, these are made from people's narratives, so I think "Personal Narratives" is a good domain. Please update the tasks in this pr and #386 accordingly. Thanks.

@swarooprm
Copy link
Contributor

@amirrezamirzaei, can you update the files so that we can go ahead in this PR?

@aarunku5
Copy link
Contributor

@amirrezamirzaei, can you update the files so that we can go ahead in this PR?

@amirrezamirzaei reminder to address the reviewer comments please

@danyaljj
Copy link
Contributor

Could you merge it with the main branch?

@aarunku5 aarunku5 merged commit 91d667d into allenai:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants