Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

feat(component): abstract upload transport into adapter #27

Merged
merged 23 commits into from
Feb 9, 2018
Merged

feat(component): abstract upload transport into adapter #27

merged 23 commits into from
Feb 9, 2018

Conversation

alexsasharegan
Copy link
Owner

@alexsasharegan alexsasharegan commented Jan 10, 2018 •
edited
Loading

Primary Goal

Abstract the upload process to an adapter interface to allow for custom upload routines like the usage of 3rd party upload SDKs (e.g. Firebase).

Secondary Goals

  • Switch dictError props from mustache-style strings with regex interpolation to user defined functions that return a string error message. Include defaults that are acceptable for display to the end user.
  • Use enums for events
  • Move all options common to uploader to an adapter options prop
  • Provide default XHR adapter that implements the existing upload transport
  • Remove vue-class-component and use built in typescript via Vue.extend to minimize build size
  • Switch to rollup to remove webpack runtime overhead

Inspired from #26

@alexsasharegan
[WIP] init commit with dep updates
f49e12c
@alexsasharegan
refactor(classes): use named export for VTransmitFile
78004dc 
BREAKING CHANGE: switch to named export of VTransmitFile class
@alexsasharegan
refactor: renaming types
5ee5b7d
@alexsasharegan
refactor(events): use enums for events
0292dbd
@alexsasharegan
refactor: rm method aliases
42b6922
@alexsasharegan
refactor: reduce cyclomatic complexity
ac24502
@alexsasharegan
refactor: shorten events enum alias
1ffd02c
@alexsasharegan
chore(docs): add lifecycle description
23e6c29
@alexsasharegan
[WIP] feat(upload-adapter): first stabs at adapter interface
03f6155
@alexsasharegan
Merge remote-tracking branch 'origin/master' into feat/upload-interce…
4947057 
…ptor
@alexsasharegan
[WIP] separating component & adapter options
aab140a 
* refactor all `dict*` string props to functions
  * conform to `err*` pattern
  * convert string templates to functions that return strings
@alexsasharegan
[WIP] XHRAdapter upload groups for cancelUpload impl
0b9a8c3
@alexsasharegan
refactor(errInvalidType): update call signature for func
0f11109
@alexsasharegan
feat(xhr-transport): initial adapter complete
93e16a8
@alexsasharegan alexsasharegan changed the title [WIP] feat(component): upload process interceptor [WIP] feat(component): abstract upload transport into adapter Jan 18, 2018
@alexsasharegan alexsasharegan changed the title [WIP] feat(component): abstract upload transport into adapter feat(component): abstract upload transport into adapter Feb 9, 2018
@alexsasharegan alexsasharegan merged commit 6cf71cf into master Feb 9, 2018
@alexsasharegan
Copy link
Owner Author

Closes #27

@alexsasharegan
Copy link
Owner Author

Closes #30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexsasharegan