fix "--" handling when interspersed is false #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced when handling
--
withapp.Interspersed(false)
set. The issue is caused by returning the--
as an argument token instead of skipping it. The change reorders the return code path, so that passing--
setsp.argsOnly = true
and then subsequently returnsp.Next()
, rather than return the arg directly.I discovered this when upgrading from v2.2.6 to v2.4.0. Previously, the
--
token was always skipped byParseContext.Next
. This change reverts the behavior in 2.4.0 to match that of 2.2.6 -- after which it seems to have been accidentally changed. I've also included test cases to validate this behavior going forward.For comparison, in
v2.2.6
the relevant code is:Thanks for your consideration!