ci(build): add node 10+ to test matrix #2522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
fast-uri, that ajv has as a dependency, was updated to v3.0.4 yesterday, which included a PR that added optional chaining. This was fine as fast-uri only tests on Node 16+ in its CI, because we only support Node 16+.
Unfortunately, we've had a few issues raised over at fast-uri with users stating issues with old Node versions when using ajv thanks to this change.
ajv is not tested on anything below Node 16, which is at odds with what ajv states to support in the readme, so this PR adds the stated supported Node versions to the CI workflow.
What changes did you make?
Added node 10, 12, and 14 to CI workflow.
Is there anything that requires more attention while reviewing?
The alternative is to update the documentation to reflect that anything under Node 16 is untested and, as such, unsupported.