fix(VirtualRenderer): fix scrollbar overlap on autocompletion

[xyos]

Description of changes:

Ace's VirtualRenderer has an issue where scrollbars sometimes overlap the content on the autocomplete container. The virtual renderer checks the logic for hiding scrollbars using the previous content size, which causes an overlap between the scrollbar and the content (see the attached video). To resolve this, the autosize calculation logic was moved before checking whether to hide the toolbar. This adjustment ensures that the next calculation of hideScrollbars considers the new size (see the second video).

scrollbar overlapping content

Screen.Recording.2025-01-08.at.2.12.50.PM.mov

fixed

Screen.Recording.2025-01-08.at.2.13.36.PM.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

• No backwards incompatible changes were made to Ace's public interface which is defined through the main typings file (ace.d.ts) and its references:
  • /~https://github.com/ajaxorg/ace/blob/master/ace.d.ts
  • /~https://github.com/ajaxorg/ace/blob/master/ace-modes.d.ts
  • /~https://github.com/ajaxorg/ace/blob/master/ace-extensions.d.ts

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (e445aaf) to head (b3def7f).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5713      +/-   ##
==========================================
+ Coverage   87.02%   87.05%   +0.03%     
==========================================
  Files         598      598              
  Lines       43593    43703     +110     
  Branches     7163     7163              
==========================================
+ Hits        37936    38047     +111     
+ Misses       5657     5656       -1     

Flag	Coverage Δ
unittests	87.05% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marinsokol5]

@nightwing wyt?

[nightwing]

This fixes the issue with popup, but I think this will cause the horizontal scrollbar to overlap instead, so we need to add some tests to cover all the edge cases of combination of scrollbars appearing after a change, to be sure that we do not introduce regression or infinite re-render loop.

[nightwing]

On autoresize demo (https://raw.githack.com/ajaxorg/ace/e0a9dedf60aab405e7b6e0727f8bf165c1fe44e1/demo/autoresize.html), if i paste

1
2
3
long long line aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

the overlapping issue happens for horizontal scrollbar now