Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested changes to fix issue 5564 #5565

Closed
wants to merge 2 commits into from
Closed

Suggested changes to fix issue 5564 #5565

wants to merge 2 commits into from

Conversation

Crivella
Copy link
Contributor

Suggested code changes to fix issue #5564

@giovannipizzi
Copy link
Member

See my comment on a suggested change: #5564 (comment)

@Crivella
Copy link
Contributor Author

I changed file_size = 1 to file_size = zipfile.ZIP64_LIMIT.
This should always cause the usage of zip64 considering that this value is compared with ZIP64_LIMIT * 1.05 in the zipfile package.

        # Compressed size can be larger than uncompressed size
        zip64 = self._allowZip64 and \
                (force_zip64 or zinfo.file_size * 1.05 > ZIP64_LIMIT)

@chrisjsewell
Copy link
Member

superceded by #5570

@Crivella Crivella deleted the fix-5564 branch June 27, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Crivella @giovannipizzi @chrisjsewell