feat: notifications #273

RobPruzan · 2025-02-25T03:57:29Z

Release: /~https://github.com/aidenybai/react-scan/releases/tag/v0.2.0

Why is this PR not merged into main yet?

Main contains issues that we didn't have time to patch. We hope to have this branch in main very soon. In the meantime all new work should branch of "precise" until this is completed

vercel · 2025-02-25T03:57:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-scan	❌ Failed (Inspect)			Feb 27, 2025 9:06pm

lxsmnsyc · 2025-02-25T05:46:22Z

.vscode/settings.json

@@ -7,7 +7,7 @@
  },
  "css.lint.unknownAtRules": "ignore",
  "[typescript]": {
-    "editor.defaultFormatter": "biomejs.biome"
+    "editor.defaultFormatter": "esbenp.prettier-vscode"


don't worry i turned linting off entirely :)

pkg-pr-new · 2025-02-25T09:11:41Z

Open in Stackblitz

npm i https://pkg.pr.new/aidenybai/react-scan@273

commit: d3f7098

lxsmnsyc · 2025-02-25T14:47:03Z

packages/scan/src/core/heatmap-overlay.ts

+  };
+  handleResizeListener = handleResize;
+
+  window.addEventListener("resize", handleResize);


no debounce/throttle?

lxsmnsyc · 2025-02-25T14:50:05Z

packages/scan/src/core/index.ts

-  const isUsedInBrowserExtension = typeof window !== 'undefined';
+  initReactScanInstrumentation({
+    onActive: () => {
+      const rdtHook = getRDTHook();


if my assumption here is correct (I haven't seen the implementation), this might not be compatible with React 18 sync SSR (not Remix-based since they cheat). Basically, the issue is that React 18 SSR is strict with the markup during hydration so any tampering would cause it throw error (in our case, inserting the toolbar and the canvas). React 19 doesn't have this issue thanks to the new SSR architecture.

This also throws an error for the CLI since the auto script runs before the document exists.

do u know how we solved this on current main?

@RobPruzan

react-scan/packages/scan/src/new-outlines/index.ts

Lines 439 to 454 in 97b9de6

const scheduleSetup = () => {

if (mounted) {

return;

}

if (schedule) {

clearTimeout(schedule);

}

schedule = requestAnimationFrame(() => {

mounted = true;

const host = getCanvasEl();

if (host) {

document.documentElement.appendChild(host);

}

setupToolbar();

}); // TODO(Alexis): perhaps a better timing

};

debounce until no commit is done to the fiber tree, which is basically two birds hit with one stone.

lxsmnsyc · 2025-02-25T14:52:20Z

packages/scan/src/core/notifications/event-tracking.ts

+  ) => {
+    toolbarEventStore.getState().actions.addEvent({
+      kind: "interaction",
+      id: crypto.randomUUID(),


future fix: needs compat check

oops missed this, should use the generateId fn we have

lxsmnsyc · 2025-02-25T14:54:25Z

packages/scan/src/core/notifications/performance-utils.ts

+const isProduction: boolean = process.env.NODE_ENV === "production";
+const prefix: string = "Invariant failed";
+
+// FIX ME THIS IS PRODUCTION INVARIANT LOL


it's fine, I do this as well LOL

lxsmnsyc · 2025-02-25T14:55:53Z

packages/scan/src/core/notifications/performance.ts

+  skipBoundaries: true,
+};
+
+const FILTER_PATTERNS = {


realistically this may not be 100% (nor 50%) accurate, unless this is intentional, of course.

oh yeah that was from monitoring a while ago. I think i had o1 think for a while and create a ton of test cases that filtered bad components, and that was the implementation that passed the most cases. Not really necessary to do this for notifications

lxsmnsyc · 2025-02-25T15:01:18Z

@popover.tsx

empty file ;)

This reverts commit 3498700.

This reverts commit 5dba046.

This reverts commit e23d073.

This reverts commit b876a3e.

This reverts commit ab672bf.

This reverts commit 4225f18.

This reverts commit 9400647.

This reverts commit 4886686.

This reverts commit e28be4d.

This reverts commit e33c26f.

This reverts commit e7e2267.

This reverts commit d1e7e63.

vercel bot deployed to Preview February 25, 2025 03:58 View deployment

lxsmnsyc reviewed Feb 25, 2025

View reviewed changes

RobPruzan force-pushed the precise branch from 924084f to ff92142 Compare February 25, 2025 09:10

vercel bot had a problem deploying to Preview February 25, 2025 09:11 Failure

RobPruzan force-pushed the precise branch from ff92142 to df48d2b Compare February 25, 2025 09:21

RobPruzan marked this pull request as ready for review February 25, 2025 09:21

vercel bot had a problem deploying to Preview February 25, 2025 09:22 Failure

RobPruzan force-pushed the precise branch from df48d2b to b88ab74 Compare February 25, 2025 09:31

vercel bot had a problem deploying to Preview February 25, 2025 09:32 Failure

RobPruzan force-pushed the precise branch from b88ab74 to a61a611 Compare February 25, 2025 10:21

vercel bot had a problem deploying to Preview February 25, 2025 10:22 Failure

feat: notifications

164ba1c

RobPruzan force-pushed the precise branch from a61a611 to 164ba1c Compare February 25, 2025 10:25

vercel bot had a problem deploying to Preview February 25, 2025 10:26 Failure

lxsmnsyc reviewed Feb 25, 2025

View reviewed changes

@popover.tsx Outdated

Copy link

Collaborator

lxsmnsyc Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty file ;)

RobPruzan reacted with thumbs up emoji

RobPruzan added 2 commits February 25, 2025 11:31

dont eagerly create canvas

7691f9d

use document element, update zindex

49b74ab

vercel bot temporarily deployed to Preview February 25, 2025 16:51 Inactive

RobPruzan added 2 commits February 25, 2025 11:57

query viewport dims

fdc3ee5

bump to 0.2.3

d6167f1

vercel bot temporarily deployed to Preview February 25, 2025 16:59 Inactive

RobPruzan added 2 commits February 25, 2025 17:25

fix: race against timeout when fetching bounding rect

5c3bbaf

bump to 0.2.4

2ba6ae7

RobPruzan added 3 commits February 26, 2025 17:37

chore: use less expensive id gen

509f8da

fix: cancel race on interaction when done

9a4eb2b

fix: dont process entries on toolbar

383a78c

vercel bot had a problem deploying to Preview February 26, 2025 23:15 Failure

fix: cleanup tasks correctly on complete

1cee690

vercel bot temporarily deployed to Preview February 26, 2025 23:31 Inactive

bump to 0.2.5

fcac0a1

vercel bot temporarily deployed to Preview February 26, 2025 23:34 Inactive

RobPruzan added 5 commits February 26, 2025 18:42

Revert "Fix toolbar mount schedule"

ab672bf

This reverts commit 3498700.

Revert "Update pnpm-lock.yaml"

dfc8b67

This reverts commit 5dba046.

Revert "Hardcode version for kitchen-sink to fixed"

9400647

This reverts commit e23d073.

Revert "Fix package linking"

4225f18

This reverts commit b876a3e.

bump to 0.2.7

2af993b

vercel bot had a problem deploying to Preview February 26, 2025 23:48 Failure

lxsmnsyc added 5 commits February 27, 2025 07:55

Reapply "Fix toolbar mount schedule"

d1e7e63

This reverts commit ab672bf.

Update index.ts

e7e2267

Reapply "Fix package linking"

e33c26f

This reverts commit 4225f18.

Reapply "Hardcode version for kitchen-sink to fixed"

e28be4d

This reverts commit 9400647.

Update pnpm-lock.yaml

4886686

vercel bot had a problem deploying to Preview February 26, 2025 23:58 Failure

Update index.ts

4fe6541

vercel bot temporarily deployed to Preview February 27, 2025 00:11 Inactive

RobPruzan added 7 commits February 27, 2025 15:44

Revert "Update pnpm-lock.yaml"

156a2cb

This reverts commit 4886686.

Revert "Reapply "Hardcode version for kitchen-sink to fixed""

604b56d

This reverts commit e28be4d.

Revert "Reapply "Fix package linking""

07af429

This reverts commit e33c26f.

Revert "Update index.ts"

a52fbcf

This reverts commit e7e2267.

Revert "Reapply "Fix toolbar mount schedule""

0946b0e

This reverts commit d1e7e63.

fix: don't use crypto to generate id's

1fa8db0

bump to 0.2.8

d3f7098

vercel bot had a problem deploying to Preview February 27, 2025 21:06 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: notifications #273

feat: notifications #273

RobPruzan commented Feb 25, 2025 •

edited

Loading

vercel bot commented Feb 25, 2025 •

edited

Loading

lxsmnsyc Feb 25, 2025

RobPruzan Feb 25, 2025

pkg-pr-new bot commented Feb 25, 2025 •

edited

Loading

lxsmnsyc Feb 25, 2025

RobPruzan Feb 25, 2025

lxsmnsyc Feb 25, 2025 •

edited

Loading

lxsmnsyc Feb 25, 2025

RobPruzan Feb 25, 2025

lxsmnsyc Feb 25, 2025

lxsmnsyc Feb 25, 2025

RobPruzan Feb 25, 2025

lxsmnsyc Feb 25, 2025

lxsmnsyc Feb 25, 2025

RobPruzan Feb 25, 2025 •

edited

Loading

lxsmnsyc Feb 25, 2025

	const scheduleSetup = () => {
	if (mounted) {
	return;
	}
	if (schedule) {
	clearTimeout(schedule);
	}
	schedule = requestAnimationFrame(() => {
	mounted = true;
	const host = getCanvasEl();
	if (host) {
	document.documentElement.appendChild(host);
	}
	setupToolbar();
	}); // TODO(Alexis): perhaps a better timing
	};

feat: notifications #273

Are you sure you want to change the base?

feat: notifications #273

Conversation

RobPruzan commented Feb 25, 2025 • edited Loading

Why is this PR not merged into main yet?

vercel bot commented Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkg-pr-new bot commented Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lxsmnsyc Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RobPruzan Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RobPruzan commented Feb 25, 2025 •

edited

Loading

vercel bot commented Feb 25, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 25, 2025 •

edited

Loading

lxsmnsyc Feb 25, 2025 •

edited

Loading

RobPruzan Feb 25, 2025 •

edited

Loading