Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Sink: Build A Quiz App #636

Closed
wants to merge 4 commits into from
Closed

Kitchen Sink: Build A Quiz App #636

wants to merge 4 commits into from

Conversation

arunavabasucom
Copy link
Contributor

@arunavabasucom arunavabasucom commented Oct 2, 2023

Please describe the changes this PR makes and why it should be merged:
This PR aims to demonstrate a quiz app example using million .
Status
Closes : #607

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 3:45pm
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 3:45pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 3:45pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aidenybai
Copy link
Owner

Please run pnpm run cleanup @arunavabasu-03

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe try using the <For/> component to replace the map you have? @deeola?
https://million.dev/docs/for

@arunavabasucom
Copy link
Contributor Author

Could you maybe try using the <For/> component to replace the map you have? @deeola? https://million.dev/docs/for

it try to do that but it with radio select it is not working properly so done with map .

@arunavabasucom
Copy link
Contributor Author

Please run pnpm run cleanup @arunavabasu-03

@aidenybai done cleanup !

@tobySolutions
Copy link
Contributor

Could you maybe try using the <For/> component to replace the map you have? @deeola? https://million.dev/docs/for

it try to do that but it with radio select it is not working properly so done with map .

Hmm, can you send a screen recording of this behaviour and your code so we can document it? Then you can revert back to map

@arunavabasucom
Copy link
Contributor Author

Could you maybe try using the <For/> component to replace the map you have? @deeola? https://million.dev/docs/for

it try to do that but it with radio select it is not working properly so done with map .

Hmm, can you send a screen recording of this behaviour and your code so we can document it? Then you can revert back to map

code -

 <For each={questions[currentQuestion].options}>
              {(option, index) => (
                <OptionLabel key={index}>
                  <OptionInput
                    type="radio"
                    value={option}
                    checked={selectedOption === option}
                    onChange={handleOptionChange}
                  />
                  {option}
                </OptionLabel>
              )}
            </For>
million_for.mp4

@tobySolutions
Copy link
Contributor

Could you maybe try using the <For/> component to replace the map you have? @deeola? https://million.dev/docs/for

it try to do that but it with radio select it is not working properly so done with map .

Hmm, can you send a screen recording of this behaviour and your code so we can document it? Then you can revert back to map

code -

 <For each={questions[currentQuestion].options}>
              {(option, index) => (
                <OptionLabel key={index}>
                  <OptionInput
                    type="radio"
                    value={option}
                    checked={selectedOption === option}
                    onChange={handleOptionChange}
                  />
                  {option}
                </OptionLabel>
              )}
            </For>

million_for.mp4
Thanks for this

@tobySolutions
Copy link
Contributor

Hey there @arunavabasu-03! This is what I have here:

Screen.Recording.2023-10-03.at.18.02.51.mov

@arunavabasucom
Copy link
Contributor Author

@tobySolutions I think it is because of your dark mode. Can you disable and check?

@tobySolutions
Copy link
Contributor

Hey there @arunavabasu-03, how are you?? The below should fix your issues, check it out and make your fixes. Thanks!

Screen.Recording.2023-10-04.at.22.52.36.mov

@tobySolutions
Copy link
Contributor

Hey there @arunavabasu-03, we already have a quiz app on the sink, but, let's review your PR and get it merged shall we?

Copy link
Contributor

@tobySolutions tobySolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobySolutions
Copy link
Contributor

I think we still have the same issue. I'm gonna merge this for future reference by the way. I think this might be an issue with styled components.

@tobySolutions tobySolutions removed the request for review from aidenybai October 6, 2023 23:02
@tobySolutions
Copy link
Contributor

I'll be closing this for now. I'll need @aidenybai and the rest of the team to look into this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitchen Sink: Build A Quiz App
5 participants