fix:configurable threshold update. #636
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikethrevale
changed the title
alinarublea
reviewed
Feb 28, 2025
| @@ -32,6 +32,8 @@ const handlerSchema = Joi.object().pattern(Joi.string(), Joi.object( | |||
| orgs: Joi.array().items(Joi.string()), | |||
| }), | |||
| enabledByDefault: Joi.boolean().required(), | |||
| movingAvgThreshold: Joi.number().min(0).optional(), | |||
| percentageChangeThreshold: Joi.number().min(0).optional(), | |||
There was a problem hiding this comment.
I think the minimal here should be at least 1
iuliag
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Could you also update the TS type? see /~https://github.com/adobe/spacecat-shared/blob/main/packages/spacecat-shared-data-access/src/models/site/index.d.ts#L63
And update the relevant unit tests? see /~https://github.com/adobe/spacecat-shared/blob/main/packages/spacecat-shared-data-access/test/unit/models/site/config.test.js#L555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!