Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for hardcoded image wait timeout on TaskImage #76

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix for hardcoded image wait timeout on TaskImage #76

merged 2 commits into from
Sep 3, 2024

Conversation

sparshev
Copy link
Collaborator

@sparshev sparshev commented Aug 22, 2024 •
edited
Loading

Found TaskImage for windows images generates successful output even for timeout on image availability waiting - so fixed that and added much more logging to easily figure out what's happening and where.

Related Issue

#74

Motivation and Context

It should be just better

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sparshev sparshev added the bug Something isn't working label Aug 22, 2024
@sparshev sparshev self-assigned this Aug 22, 2024
@sparshev
Added wait for snapshot task operation completion
48bf6f2 
Otherwise it's hard to find out if the snapshot is yet completed or not
@sparshev sparshev changed the title Prepared fix for the hardcoded image wait timeout on TaskImage Fix for the hardcoded image wait timeout on TaskImage and Performance improvement Sep 3, 2024
@sparshev sparshev changed the title Fix for the hardcoded image wait timeout on TaskImage and Performance improvement Performance improvement and Fix for the hardcoded image wait timeout on TaskImage Sep 3, 2024
@sparshev sparshev force-pushed the timeout_bugfix_better_logging branch from efb2f68 to 719fd91 Compare September 3, 2024 03:54
@sparshev sparshev added the enhancement New feature or request label Sep 3, 2024
@sparshev sparshev force-pushed the timeout_bugfix_better_logging branch from ff79fe4 to 68e7846 Compare September 3, 2024 04:18
@sparshev sparshev changed the title Performance improvement and Fix for the hardcoded image wait timeout on TaskImage API Perf improvement and Fix for hardcoded image wait timeout on TaskImage Sep 3, 2024
@sparshev sparshev force-pushed the timeout_bugfix_better_logging branch from 68e7846 to 48bf6f2 Compare September 3, 2024 16:25
@sparshev sparshev changed the title API Perf improvement and Fix for hardcoded image wait timeout on TaskImage Fix for hardcoded image wait timeout on TaskImage Sep 3, 2024
@sparshev sparshev merged commit f1537d7 into main Sep 3, 2024
9 checks passed
@sparshev sparshev deleted the timeout_bugfix_better_logging branch September 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sparshev sparshev

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sparshev