drop support for .NET Core 2.1

adamralph · Aug 19, 2021 · 4ccb3c9 · 4ccb3c9
1 parent ef1395e
commit 4ccb3c9
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 18 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,12 +24,6 @@ jobs:
             tests:
               framework: net5.0
               sdk: "5.0.301"
-          - job:
-              os: ubuntu-20.04
-              build: ./build.sh
-            tests:
-              framework: netcoreapp2.1
-              sdk: "2.1.816"
           - job:
               os: ubuntu-20.04
               build: ./build.sh

diff --git a/MinVer.Lib/MinVer.Lib.csproj b/MinVer.Lib/MinVer.Lib.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/MinVer/MinVer.csproj b/MinVer/MinVer.csproj
@@ -18,7 +18,7 @@
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <RollForward>major</RollForward>
     <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/MinVerTests.Infra/MinVerCli.cs b/MinVerTests.Infra/MinVerCli.cs
@@ -20,6 +20,6 @@ public static class MinVerCli
         }
 
         public static string GetPath(string configuration) =>
-            Solution.GetFullPath($"minver-cli/bin/{configuration}/netcoreapp2.1/minver-cli.dll");
+            Solution.GetFullPath($"minver-cli/bin/{configuration}/netcoreapp3.1/minver-cli.dll");
     }
 }
diff --git a/MinVerTests.Infra/MinVerTests.Infra.csproj b/MinVerTests.Infra/MinVerTests.Infra.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net5.0</TargetFrameworks>
+    <TargetFrameworks>netcoreapp3.1;net5.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/MinVerTests.Lib/MinVerTests.Lib.csproj b/MinVerTests.Lib/MinVerTests.Lib.csproj
@@ -2,11 +2,7 @@
 
   <PropertyGroup>
     <RollForward>major</RollForward>
-    <TargetFrameworks>netcoreapp2.1;netcoreapp3.1;net5.0</TargetFrameworks>
-  </PropertyGroup>
-
-  <PropertyGroup>
-    <CopyLocalLockFileAssemblies Condition="'$(TargetFramework)' == 'netcoreapp2.1'">true</CopyLocalLockFileAssemblies>
+    <TargetFrameworks>netcoreapp3.1;net5.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/MinVerTests.Packages/MultipleProjects.cs b/MinVerTests.Packages/MultipleProjects.cs
@@ -15,7 +15,7 @@ public class MultipleProjects
 
         public MultipleProjects(ITestOutputHelper output) => this.output = output;
 
-        // for some reason, when using SDK 2.1 or 3.1,
+        // for some reason, when using SDK 3.1,
         // there is a 15 minute delay after the `dotnet build` command,
         // so we only run this test on SDK 5.0 and later
         [Net5PlusFact]

diff --git a/README.md b/README.md
@@ -26,7 +26,7 @@ Also available as a [command line tool](#can-i-use-minver-to-version-software-wh
 
 ## Prerequisites
 
-- [.NET Core SDK 2.1 or later](https://www.microsoft.com/net/download)
+- [.NET Core SDK 3.1 or later](https://www.microsoft.com/net/download)
 - [Git](https://git-scm.com/)
 
 ## Quick start

diff --git a/minver-cli/minver-cli.csproj b/minver-cli/minver-cli.csproj
@@ -13,7 +13,7 @@
     <PackageReleaseNotes>/~https://github.com/adamralph/minver/blob/main/CHANGELOG.md</PackageReleaseNotes>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <RollForward>major</RollForward>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
     <ToolCommandName>minver</ToolCommandName>
   </PropertyGroup>