Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for the PUBLISH+UNSUBACK case #236

Merged
merged 1 commit into from
Jan 19, 2025
Merged

add test for the PUBLISH+UNSUBACK case #236

merged 1 commit into from
Jan 19, 2025

Conversation

vladak
Copy link
Contributor

@vladak vladak commented Jan 19, 2025

This is a follow-up to PR #225

@vladak vladak mentioned this pull request Jan 19, 2025
Merged
dhalbert
dhalbert approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tests are always a good idea.

@dhalbert dhalbert merged commit d4b87d2 into adafruit:main Jan 19, 2025
1 check passed
@dhalbert
Copy link
Contributor

This PR had a test failure when it was merged: /~https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT/actions/runs/12854246695/job/35838388261. I think the timing test maybe should be made wider

@vladak
Copy link
Contributor Author

vladak commented Jan 19, 2025

will take a look later today.

@vladak
Copy link
Contributor Author

vladak commented Jan 19, 2025

This was another case of test_recv_timeout.py failing (i.e. not related to this change), this time with:

FAILED tests/test_recv_timeout.py::RecvTimeout::test_recv_timeout_vs_keepalive - assert (225.125585554 - 216.917325518) <= (8 + 0.2)

so it looks like it would not hurt bumping the adjustment value to 0.3.

@dhalbert dhalbert mentioned this pull request Jan 19, 2025
Open
@vladak vladak mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @dhalbert