Update minimqtt_adafruitio_native_networking.py #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer versions of the miniMQTT library seem to break when you put the whole key for the feed in there. `foo/feed/group.feed` no longer works ( [this breaks it](/~https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/ece3e396ccb5504558f6b11423a96d06a6dfb5c9/adafruit_io/adafruit_io.py#L43-L54) ), but instead it needs to be just `group.feed`.
|
@brentru This I am unsure about. Could you review? I can include it in the release for the |
|
@dhalbert Changes in the PR look good to me, good idea w/ merging to release with the send fix. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 3, 2025
Updating /~https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.3.1 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#45 from FoamyGuy/reset_sleep_ms Updating /~https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.2.20 from 1.2.19: > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#20 from FoamyGuy/type_annotations Updating /~https://github.com/adafruit/Adafruit_CircuitPython_PCF8575 to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8575#8 from FoamyGuy/value_return_bool Updating /~https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.4.15 from 1.4.14: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#34 from FoamyGuy/min_delay_continuous Updating /~https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.11.0 from 7.10.5: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#232 from vladak/send_bytes_eagain > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#226 from vladak/connect_session_id > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#229 from manchicken/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#231 from dhalbert/partial-send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer versions of the miniMQTT library seem to break when you put the whole key for the feed in there.
foo/feed/group.feedno longer works ( this breaks it ), but instead it needs to be justgroup.feed.