Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert base JS file to plain JS #81

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Convert base JS file to plain JS #81

merged 1 commit into from
Jan 19, 2019

Conversation

deivid-rodriguez
Copy link
Member

The autodeploy triggered after merging #80 failed. The good news is that autodeploys are working :)

This PR should fix it by converting the base JS file to plain JS since ActiveAdmin 2.0 no longer depends on coffeescript.

Since ActiveAdmin 2.0 no longer depends on coffeescript.
@deivid-rodriguez deivid-rodriguez requested a review from a team January 19, 2019 14:21
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let’s get this auto deployed. 😎

@javierjulio javierjulio merged commit 71fded9 into master Jan 19, 2019
@javierjulio javierjulio deleted the fix_deploy branch January 19, 2019 14:29
@deivid-rodriguez
Copy link
Member Author

It was a bit of a nightmare to get this deployed. The old cached coffeescript assets were still used, but the coffeescript dependency was no longer present, so asset precompilation would fail.

I finally managed to deploy by running

heroku plugins:install heroku-repo
heroku repo:purge_cache -a demo-activeadmin-owned

And then triggering a manual deploy of master.

Not sure if this is the recommended solution for this problem, I got it from this thread. Also increasing assets.version in Rails config is suggested there.

We should probably keep this in mind for the upgrade to Active Admin 2.0, and maybe ask the heroku people about it.

@javierjulio
Copy link
Member

Sounds good, thanks David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants