-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for a different distribution URI #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I
const potential: string = versions[i].version; | ||
const semverPotential = semver.coerce(potential); | ||
if (semverPotential === null) | ||
continue; | ||
const satisfied: boolean = semver.satisfies(potential, versionSpec); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
I think { includePrerelease: true }
should be added here, otherwise it won't match version numbers like v12.22.12-rc.0
.
@dmitry-shibanov would anyone at GH be able to review and land this? Would be awesome to be able to test our projects against upcoming node releases and possibly avoid this list nodejs/node#44626 (comment) 🙂 |
Hello @SimenB. For now we're working on adding support for node rc/nightly versions and other possible nodejs mirrors. We're investigating possible solutions for now. |
Ah, cool! Happy to hear it's something you're working on 👍 |
Hello everyone. For now I'm going to close the pull request because we added support for nightly, rc and canary builds in scope of this pull request. If you need any additional distributions you should create a feature request. |
Description:
In order to support canary and nightly builds in the nodejs project llnode we have added support for a different distribution url to be supplied by the build.
This PR is a request to integrate this with setup-node to encourage the use of this approach in the community as it will give project owners a simple way to test against up and coming releases
If there are any improvements or a different approach preferred I'd love to get the feedback.
Usage:
Related issue:
Install nightly builds #80
Check list: