Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance curl version warning #2922

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Enhance curl version warning #2922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/main.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,25 @@ int main(string[] cliArgs) {
string curlWarningMessage = format("WARNING: Your curl/libcurl version (%s) has known HTTP/2 bugs that impact the use of this application.", curlVersion);
addLogEntry();
addLogEntry(curlWarningMessage);
addLogEntry(" Please report this to your distribution and request that they provide a newer version for your platform or upgrade this yourself.");
addLogEntry(" Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself.");
addLogEntry(" Downgrading all application operations to use HTTP/1.1 to ensure maximum operational stability.");
addLogEntry(" Please read /~https://github.com/abraunegg/onedrive/blob/master/docs/usage.md#compatibility-with-curl for more information.");
addLogEntry();
appConfig.setValueBool("force_http_11" , true);
}
} else {
// get the curl version - a bad curl version may still be in use
string curlVersion = getCurlVersionNumeric();

// Is the version of curl or libcurl being used by the platform a known bad curl version
if (isBadCurlVersion(curlVersion)) {
// add warning message
string curlWarningMessage = format("WARNING: Your curl/libcurl version (%s) has known operational bugs that impact the use of this application.", curlVersion);
addLogEntry();
addLogEntry(curlWarningMessage);
addLogEntry(" Please report this to your distribution and request that they provide a newer curl version for your platform or upgrade this yourself.");
addLogEntry();
}
}

// If --disable-notifications has not been used, check if everything exists to enable notifications
Expand Down
Loading