Properly set Error.StatusCode #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #154 newError was completely ingoring response status code. It was wrongly deriving it from error code. This patch ensures Error,StatusCode is set with correct response status.
tcard
reviewed
Apr 23, 2020
| @@ -54,3 +59,83 @@ func TestIssue127ErrorResponse(t *testing.T) { | |||
| assert.NotNil(t, err) | |||
| assert.Contains(t, err.Error(), errMsg) | |||
| } | |||
|
|
|||
| func TestIssue_154(t *testing.T) { | |||
There was a problem hiding this comment.
This tests a number of things that have nothing to do with #154. We just want to check that a HTTP response with 400 status code and non-JSON or MsgPack body turns into an ErrorInfo with 400 status code.
There are other tests that test retries and fallbacks.
|
@tcard PTAL I added a simpler test where I only check to see the StatusCode is properly set in Error on not json/msgpack mime types. |
tcard
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #154
newError was completely ignoring response status code.
It was wrongly deriving it from error code.
This patch ensures Error,StatusCode is set with correct response status.