RSA7b3 #356
Merged
RSA7b3 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
| // TODO: Realtime.connection | ||
| it("should CONNECTED ProtocolMessages contain a clientId") { | ||
| let options = AblyTests.commonAppSetup() | ||
| options.clientId = "john" |
There was a problem hiding this comment.
This is not a great test because it appears the clientId is set to john before the ProcotolMessage is received. You should have a null clientId but use a token with an implicit clientId and then check that the client library later sets the clientId based solely on the connectionDetails.clientId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.