[Groundwork for #1201] Remove capture in Quick method call trailing closures #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
1201-remove-capture-in-it-trailing-closure
branch
from
ee77bbd to
f5bbcbf
Compare
lawrence-forooghian
changed the title
it trailing closure
lawrence-forooghian
requested review from
ben-xD,
lukasz-szyszkowski,
maratal and
QuintinWillison
maratal
approved these changes
Nov 25, 2021
lawrence-forooghian
force-pushed
the
1201-remove-capture-in-it-trailing-closure
branch
from
f5bbcbf to
79f0887
Compare
lukasz-szyszkowski
approved these changes
Nov 25, 2021
There’s no need for these to be instance variables. We’re not mutating anything, it’s just static testing data. The motivation for this change is that it’s groundwork for removing the Quick testing framework using an automated migrator tool (#1201). The migrator that I’m writing won’t be able to handle the capture lists in the QuickSpec method call trailing closures, so I’m replacing them.
We can, so we should.
lawrence-forooghian
force-pushed
the
1201-remove-capture-in-it-trailing-closure
branch
from
79f0887 to
d61536a
Compare
lawrence-forooghian
deleted the
1201-remove-capture-in-it-trailing-closure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Removes a capture in some trailing closures in the tests. See commit message for more details.
Whilst I was there, I also changed some
vars tolets.Does it change the behaviour of the test suite?
No, it's just a refactor.
Why are we doing this?
It’s groundwork for removing the Quick testing framework using an automated migrator tool (#1201). The
migrator that I’m writing won’t be able to handle the capture lists in the QuickSpec method call trailing closures, so I’m replacing them.