Improve test file structure and naming #1191
Conversation
I think it’s a bit confusing to have them both mixed into a single list.
This makes them: - more descriptively named - easier to find through a fuzzy file matcher that only matches on the basename, like Xcode’s “Open Quickly”
lawrence-forooghian
force-pushed
the
improve-test-file-structure-and-naming
branch
from
5b13c7d to
769ad34
Compare
QuintinWillison
requested review from
QuintinWillison,
lukasz-szyszkowski and
maratal
|
I've removed review requests, given this pull request is in draft state, has conflicts and failing checks. @lawrence-forooghian, it would be helpful if you could update here as to current status and close if that's appropriate. Thanks. |
|
Thanks for that @QuintinWillison. I held off on merging / chasing reviewers for this earlier since it was failing CI presumably due to flaky tests. Since this PR is going to end up with merge conflicts (and hence need another hard-to-get-green CI run) pretty much every time anything gets merged into I've created #1203 to make sure we revisit, and am closing this PR. |
lawrence-forooghian
deleted the
improve-test-file-structure-and-naming
branch
This hopefully makes our test files easier to navigate, by separating test files from test utilities, and naming the test files to make it clear they’re tests. See commit messages for more details.