Skip to content

Commit

Permalink
Fix premature discarding of fallback host
Browse files Browse the repository at this point in the history
Running RestClientTests on my development machine reveals multiple test
failures which are caused by the fact that the SDK incorrectly believes
that the timeout described by RSC15f has elapsed.

The underlying cause is that we're not initializing the value pointed to
by the `oldlenp` pointer passed to `sysctl`.

These tests are not failing in CI, which leads me to wonder if the
symptoms only manifest on ARM devices (e.g. my development machine). We
don't have an quick way of running our unit tests on actual iOS devices
so I haven't been able to confirm if they're affected.

Resolves #1683.
  • Loading branch information
lawrence-forooghian committed Apr 19, 2023
1 parent f25c19c commit aef5062
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/ARTTime.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ @implementation ARTTime
+ (double) timeSinceBoot {

int mib[2];
size_t size;
size_t size = sizeof(bootTime);

/**
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/sysctl.3.html
Expand Down

0 comments on commit aef5062

Please sign in to comment.