-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable mandatory TLS verification with --insecure #1401
Disable mandatory TLS verification with --insecure #1401
Conversation
@d4xfe Thank you, looks excellent considering this is your first PR. Congratulations. Can you please:
|
@abhinavsingh Thanks. I've synced the branches and I don't conflicts anymore. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
- Coverage 84.57% 84.37% -0.20%
===========================================
Files 177 178 +1
Lines 8103 8130 +27
Branches 1239 1242 +3
===========================================
+ Hits 6853 6860 +7
- Misses 1052 1059 +7
- Partials 198 211 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@d4xfe Thank you for this work and the PR. There are some workflow issues. I am going create a new PR based on top of your contribution and try to this ship. |
getpeercert()
only returns the certificate with enabled certificate validation. Because of this, I updated it togetpeercert(True)
, which will return a binary blob of the servers certificate regardless of the verification mode.I added the util method
cert_der_to_dict
usingssl
internals to convert the blob to a python dict likegetpeercert()
would.The flag
--insecure
was introduced to disable certificate validation of ssl sockets.This allows TLS interception when the server is using a self-signed certificate.
This is my first pull request on GitHub and I'm still a bit confused. So if I should change anything let me know.