Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for rotate FX behaviour when Pillow is not installed #1544

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Add tests for rotate FX behaviour when Pillow is not installed #1544

merged 3 commits into from
Apr 15, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Apr 15, 2021 •
edited
Loading

Add tests for rotate FX when Pillow is not installed (moviepy/video/fx/rotate.Image is None). Contributes to #1355

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general. fx Related to advanced effects applied via clip.fx(), or effects in general. labels Apr 15, 2021
@mondeja mondeja mentioned this pull request Apr 15, 2021
Closed
@coveralls
Copy link

coveralls commented Apr 15, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 68.502% when pulling 24dbd3b on mondeja:test-rotate-without-PIL into 7dc2791 on Zulko:master.

@mondeja mondeja merged commit f3c6342 into Zulko:master Apr 15, 2021
@mondeja mondeja deleted the test-rotate-without-PIL branch April 15, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fx Related to advanced effects applied via clip.fx(), or effects in general. tests Related to individual tests in the test suite or running the test suite. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondeja @coveralls