Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced double pipe with middle dot #1259

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

YamatoSecurity
Copy link
Collaborator

Closes #1258
Please check whenever you have time.

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Jan 26, 2024
@YamatoSecurity YamatoSecurity added this to the v2.13.0 milestone Jan 26, 2024
@YamatoSecurity YamatoSecurity self-assigned this Jan 26, 2024
Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fd81b32) 82.43% compared to head (4c60b34) 82.20%.

Files Patch % Lines
src/timeline/search.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   82.43%   82.20%   -0.23%     
==========================================
  Files          27       27              
  Lines       24700    24305     -395     
==========================================
- Hits        20361    19981     -380     
+ Misses       4339     4324      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with command prompt and PowerShell :) LGTM!!🚀

@YamatoSecurity YamatoSecurity merged commit 812c56b into main Jan 27, 2024
9 checks passed
@hitenkoku hitenkoku deleted the 1258-middle-dot-separator branch January 27, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace double vertical line character with a middle dot character
3 participants