Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tencent cos #260

Merged
merged 8 commits into from
Mar 17, 2023
Merged

feat: support tencent cos #260

merged 8 commits into from
Mar 17, 2023

Conversation

leizhiyuan
Copy link
Contributor

support tencent cos , test case can run in local

@leizhiyuan leizhiyuan mentioned this pull request Mar 17, 2023
Closed
Xuanwo
Xuanwo reviewed Mar 17, 2023
View reviewed changes
src/tencent/config.rs Outdated Show resolved Hide resolved
@leizhiyuan
Copy link
Contributor Author

image

I tested in my local machine with right key

@Xuanwo
Copy link
Owner

Xuanwo commented Mar 17, 2023

Thanks a lot! Please format code with cargo fmt --all, others LGTM.

Xuanwo
Xuanwo reviewed Mar 17, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@leizhiyuan
Copy link
Contributor Author

remove all new deps

@Xuanwo
Copy link
Owner

Xuanwo commented Mar 17, 2023

Thanks a lot!

@Xuanwo Xuanwo merged commit e98eacf into Xuanwo:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leizhiyuan @Xuanwo