Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check version of cryptography module #18

Merged
merged 2 commits into from
Oct 28, 2018

Conversation

yol
Copy link
Member

@yol yol commented Oct 19, 2018

We have had multiple issues with Ubuntu 16.04 using an outdated version
of the Python cryptography module that causes strange SSL behavior.
Example for this is not being able to connect to SSL sites.

This commit introduces a check on Kodi startup so the user is aware
of the issue.

See also:
pyca/pyopenssl#542 (comment)
https://forum.kodi.tv/showthread.php?tid=335786

xbmc/xbmc#14512

@yol
Copy link
Member Author

yol commented Oct 19, 2018

@wsnipex @MartijnKaijser

This now displays a dialog that the user has to confirm at every start. Too obtrusive?

@wsnipex
Copy link
Contributor

wsnipex commented Oct 19, 2018

I think it's ok. Maybe we can add some pointer how to upgrade? i.e short URL to https://forum.kodi.tv/showthread.php?tid=304613&pid=2553425#pid2553425 that explains it for ubuntu

@yol
Copy link
Member Author

yol commented Oct 19, 2018

@kib can you make a short URL with https://kodi.tv/?

@MartijnKaijser
Copy link
Member

Perhaps just put it on the wiki page?
https://kodi.wiki/view/HOW-TO:Install_Kodi_for_Linux

@yol
Copy link
Member Author

yol commented Oct 22, 2018

What do you mean? You want to link there? That's quite annoying for the user to type.

@MartijnKaijser
Copy link
Member

No put the info there and create a short link instead of to some random forum post

@yol
Copy link
Member Author

yol commented Oct 23, 2018

Still need @kib to make a shortlink nudge

@yol
Copy link
Member Author

yol commented Oct 23, 2018

@wsnipex Do you want to make the Wiki changes? I can in theory do it but I don't use Ubuntu at all so I'd much prefer if someone that actually performed the steps wrote about it.

@MartijnKaijser
Copy link
Member

https://kodi.wiki/view/Ubuntu or https://kodi.wiki/view/Linux can be uses and will land on the general wiki page.
I'm not sure about creating extra link because of link rot that might happen over time.

We have had multiple issues with Ubuntu 16.04 using an outdated version
of the Python cryptography module that causes strange SSL behavior.
Example for this is not being able to connect to SSL sites.

This commit introduces a check on Kodi startup so the user is aware
of the issue.

See also:
pyca/pyopenssl#542 (comment)
https://forum.kodi.tv/showthread.php?tid=335786
@yol yol force-pushed the check-python-cryptography branch from 8f8b731 to 4346d73 Compare October 28, 2018 12:20
@yol
Copy link
Member Author

yol commented Oct 28, 2018

Updated. Good to merge?

@yol
Copy link
Member Author

yol commented Oct 28, 2018

@MartijnKaijser MartijnKaijser merged commit 3062f34 into XBMC-Addons:master Oct 28, 2018
@yol yol deleted the check-python-cryptography branch October 30, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants