Editor: Revert bulk editing support for post actions #69341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -52 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f38c49b. 🔍 Workflow run URL: /~https://github.com/WordPress/gutenberg/actions/runs/13560355244
|
t-hamano
reviewed
Feb 27, 2025
|
Thanks for testing, @t-hamano! |
Mamaduka
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A temporary resolution for #67872.
PR partially reverts changes from #67743 and avoids triggering
useSelectwarnings in the editor.Note
I've also noticed another warning for Quick Edit coming from the
TemplateEditcomponent. I'm working to resolve it separately. Ref #66591.Update: It will be handled via #69344.
Why?
The bulk editing support is an experimental feature for DataViews, while the warnings also affect post-editors.
How?
I tried to keep the changes to a minimum. The code is mainly reverted from the
PostActionscomponent, which is now rendered conditionally when a single item is selected.Testing Instructions
Ensure that the Gutenberg build is running in dev mode.
Editor
Experimental Quick Edit
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-02-27.at.10.16.23.mp4