Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring boolsets #263

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Refactoring boolsets #263

merged 2 commits into from
Mar 17, 2021

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented Mar 17, 2021

some refactoring to remove unnecessary code and making it easier to add new boolean constraint.
This will make #259 easier

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #263 (3e4a856) into master (77c0adf) will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   96.56%   97.28%   +0.72%     
==========================================
  Files          49       48       -1     
  Lines        3843     4126     +283     
==========================================
+ Hits         3711     4014     +303     
+ Misses        132      112      -20     
Impacted Files Coverage Δ
src/constraints/and.jl 100.00% <ø> (ø)
src/constraints/or.jl 96.66% <ø> (-1.16%) ⬇️
src/MOI_wrapper/Bridges/bool.jl 97.32% <100.00%> (+0.65%) ⬆️
src/MOI_wrapper/Bridges/indicator.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/Bridges/reified.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/bool.jl 92.30% <100.00%> (ø)
src/MOI_wrapper/constraints.jl 99.54% <100.00%> (+0.03%) ⬆️
src/constraints/boolset.jl 100.00% <100.00%> (ø)
src/types.jl 99.05% <100.00%> (+17.97%) ⬆️
src/util.jl 97.97% <100.00%> (+0.47%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c0adf...3e4a856. Read the comment docs.

@Wikunia
Copy link
Owner Author

Wikunia commented Mar 17, 2021

Benchmark Report for ConstraintSolver

Job Properties

  • Time of benchmarks:
    • Target: 17 Mar 2021 - 16:55
    • Baseline: 17 Mar 2021 - 17:09
  • Package commits:
    • Target: 3e4a85
    • Baseline: 77c0ad
  • Julia commits:
    • Target: 96786e
    • Baseline: 96786e
  • Julia command flags:
    • Target: -O3
    • Baseline: -O3
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["steiner", "steiner_7"] 1.01 (5%) 1.01 (1%) ❌

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["eternity"]
  • ["graph_coloring"]
  • ["killer_sudoku"]
  • ["lp"]
  • ["scheduling"]
  • ["steiner"]
  • ["sudoku"]

Julia versioninfo

Target

Julia Version 1.5.0
Commit 96786e22cc (2020-08-01 23:44 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.9.14-arch1-1 #1 SMP PREEMPT Sat, 12 Dec 2020 14:37:12 +0000 x86_64 unknown
  CPU: Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz: 
                 speed         user         nice          sys         idle          irq
       #1-12  3791 MHz   10251806 s    1140646 s    5405015 s  7781304625 s     880698 s
       
  Memory: 46.9886360168457 GB (1147.73828125 MB free)
  Uptime: 6.501419e6 sec
  Load Avg:  1.25390625  1.12744140625  0.7412109375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, sandybridge)

Baseline

Julia Version 1.5.0
Commit 96786e22cc (2020-08-01 23:44 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.9.14-arch1-1 #1 SMP PREEMPT Sat, 12 Dec 2020 14:37:12 +0000 x86_64 unknown
  CPU: Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz: 
                 speed         user         nice          sys         idle          irq
       #1-12  3541 MHz   10252530 s    1222543 s    5407916 s  7782226531 s     880905 s
       
  Memory: 46.9886360168457 GB (720.45703125 MB free)
  Uptime: 6.502259e6 sec
  Load Avg:  1.189453125  1.14111328125  1.0185546875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, sandybridge)

@Wikunia Wikunia merged commit b712b8d into master Mar 17, 2021
@Wikunia Wikunia deleted the refactoring-bool-constraints branch March 17, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant